Set mipLevelCount and arrayLayerCount to 0 in TextureViewDescriptor by default#407
Merged
kainino0x merged 3 commits intogpuweb:masterfrom Aug 22, 2019
Merged
Conversation
…reViewDescriptor The default value of mipLevelCount and arrayLayerCount should be 0 in TextureViewDescriptor to specify the texture view will cover all the mipmap levels and array layers of the original texture when base mipmap level and base array layer is also 0.
kvark
reviewed
Aug 13, 2019
spec/index.bs
Outdated
| </script> | ||
|
|
||
| * {{GPUTextureViewDescriptor/mipLevelCount}}: | ||
| If mipLevelCount == 0, baseMipLevel must also be 0 and the texture view will cover all the mipmap levels of the original texture. |
Contributor
There was a problem hiding this comment.
We don't actually need this restriction. We could say that the mipLevelCount, if 0, covers all the mips starting from the baseMipLevel
kainino0x
approved these changes
Aug 13, 2019
kvark
approved these changes
Aug 14, 2019
kdashg
approved these changes
Aug 15, 2019
Contributor
|
Looks good; merging with 2 spec editor reviews. Thanks! |
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
* Port all the remaining docs from HackMD and wiki * address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value of mipLevelCount and arrayLayerCount should be 0 in
TextureViewDescriptor to specify the texture view will cover all the
mipmap levels and array layers of the original texture when base mipmap
level and base array layer is also 0.
Preview | Diff