Add feature for filterable *32float textures#3828
Merged
kainino0x merged 2 commits intogpuweb:mainfrom Mar 2, 2023
Merged
Conversation
Contributor
|
Previews, as seen when this build job started (823235a): |
Member
|
We currently have this line in the spec:
I think we either need a separate column for blending or decide if we should also require blending (see #3556 (comment) for a complete picture). |
Contributor
Author
|
Thank you for catching that, I forgot we wrote that. I'll fix this for now but we should talk about whether to combine the two features. |
Contributor
Author
|
Commented over in #3556 (comment), I don't think we can combine them. |
kainino0x
added a commit
to kainino0x/gpuweb
that referenced
this pull request
Feb 16, 2023
Previously this was just "filterable && renderable" but that's kind of buried and prone to getting updated incorrectly. Confirmed in gpuweb#3566 that rg11b10ufloat is always blendable when it's renderable. This change is in service of gpuweb#3828 which will add cases for which "filterable && renderable" isn't true.
This was referenced Feb 16, 2023
a78f7ff to
566aa51
Compare
kainino0x
added a commit
that referenced
this pull request
Feb 16, 2023
Previously this was just "filterable && renderable" but that's kind of buried and prone to getting updated incorrectly. Confirmed in #3566 that rg11b10ufloat is always blendable when it's renderable. This change is in service of #3828 which will add cases for which "filterable && renderable" isn't true.
566aa51 to
f06a52a
Compare
Contributor
GPU Web F2F 2023-02-16/17
|
Contributor
Author
|
review ping @toji |
toji
approved these changes
Mar 2, 2023
Member
toji
left a comment
There was a problem hiding this comment.
Apologies for the slow review. Thought I had already approved this one.
LGTM!
juj
added a commit
to juj/wasm_webgpu
that referenced
this pull request
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3601
Tacit resolution queue since we hadn't chosen a name for the feature until now.