Skip to content

Add column for whether format is blendable#3833

Merged
kainino0x merged 1 commit intogpuweb:mainfrom
kainino0x:blendable
Feb 16, 2023
Merged

Add column for whether format is blendable#3833
kainino0x merged 1 commit intogpuweb:mainfrom
kainino0x:blendable

Conversation

@kainino0x
Copy link
Copy Markdown
Contributor

Previously this was just "filterable && renderable" but that's kind of buried and prone to getting updated incorrectly.
Confirmed in #3566 that rg11b10ufloat is always blendable when it's renderable.

This change is in service of #3828 which will add cases for which "filterable && renderable" isn't true.

Previously this was just "filterable && renderable" but that's kind of
buried and prone to getting updated incorrectly.
Confirmed in gpuweb#3566 that rg11b10ufloat is always blendable when it's
renderable.

This change is in service of gpuweb#3828 which will add cases for which
"filterable && renderable" isn't true.
@kainino0x kainino0x added the copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) label Feb 16, 2023
@kainino0x kainino0x requested a review from toji February 16, 2023 01:11
@kainino0x
Copy link
Copy Markdown
Contributor Author

Also @teoxoy PTAL

@github-actions
Copy link
Copy Markdown
Contributor

Previews, as seen when this build job started (281da79):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

Copy link
Copy Markdown
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kainino0x
Copy link
Copy Markdown
Contributor Author

Merging with Teo's review to unblock other PRs

@kainino0x kainino0x merged commit a89ffba into gpuweb:main Feb 16, 2023
@kainino0x kainino0x deleted the blendable branch February 16, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants