Reject redundant map requests early so there are never multiple pending promises#3348
Merged
kainino0x merged 2 commits intogpuweb:mainfrom Aug 22, 2022
Merged
Reject redundant map requests early so there are never multiple pending promises#3348kainino0x merged 2 commits intogpuweb:mainfrom
kainino0x merged 2 commits intogpuweb:mainfrom
Conversation
…ng promises Fixes issue 3271
Contributor
Author
|
Not sure if Jim is still out, but @nical you might be interested in reviewing this change (sorry, should have cc'd you originally, forgot) |
|
LGTM |
takahirox
added a commit
to takahirox/cts
that referenced
this pull request
Nov 26, 2022
With this WebGPU spec change gpuweb/gpuweb#3348 buffer.mapAsync() rejects immediately if it is pending map. This commit adds a test to check it.
7 tasks
kainino0x
pushed a commit
to gpuweb/cts
that referenced
this pull request
Nov 29, 2022
With this WebGPU spec change gpuweb/gpuweb#3348 buffer.mapAsync() rejects immediately if it is pending map. This commit adds a test to check it.
blueboxd
pushed a commit
to blueboxd/dawn
that referenced
this pull request
Nov 30, 2022
To reflect the WebGPU spec change at gpuweb/gpuweb#3348 Bug: chromium:1355994 Change-Id: I0159cbd9e1977a05453e3c562a2b0649a0ff930f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/110448 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Takahiro <hogehoge@gachapin.jp> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3271