Test buffer.mapAsync() early rejection#2033
Merged
kainino0x merged 1 commit intogpuweb:mainfrom Nov 29, 2022
Merged
Conversation
With this WebGPU spec change gpuweb/gpuweb#3348 buffer.mapAsync() rejects immediately if it is pending map. This commit adds a test to check it.
|
Previews, as seen when this build job started (f831bef): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this WebGPU spec change gpuweb/gpuweb#3348
buffer.mapAsync()rejects immediately if it is pending map. This commit adds a test to check it.The test is based on https://bugs.chromium.org/p/chromium/issues/detail?id=1355994#c3 that @kainino0x suggested.
Issue: #2009
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.