[editorial] Describe the fragment stage of the rendering algorithm#2162
Merged
kvark merged 6 commits intogpuweb:mainfrom Dec 1, 2021
Merged
[editorial] Describe the fragment stage of the rendering algorithm#2162kvark merged 6 commits intogpuweb:mainfrom
kvark merged 6 commits intogpuweb:mainfrom
Conversation
52d3845 to
603267a
Compare
Contributor
kainino0x
reviewed
Nov 2, 2021
Contributor
kainino0x
approved these changes
Nov 30, 2021
spec/index.bs
Outdated
|
|
||
| Issue: define barycentric coordinates | ||
| Issue: define the depth computation algorithm | ||
| framebufferCoords(n) = vector(|vp|.`x` + 0.5×(|n|.x+1)×|vp|.`width`, |vp|.`y` + .5×(|n|.y+1)×|vp|.`height`) |
Contributor
There was a problem hiding this comment.
Suggested change
| framebufferCoords(n) = vector(|vp|.`x` + 0.5×(|n|.x+1)×|vp|.`width`, |vp|.`y` + .5×(|n|.y+1)×|vp|.`height`) | |
| framebufferCoords(|n|) = vector(|vp|.`x` + 0.5 × (|n|.x + 1) × |vp|.`width`, |vp|.`y` + .5 × (|n|.y + 1) × |vp|.`height`) |
Spaces seem more consistent and help distinguish × from x.
Alternatively could use · (·)
Also I think this should specify depth as well? Somewhere the NDC z needs to get mapped to the viewport (https://github.com/gpuweb/cts/blob/main/src/webgpu/api/operation/rendering/depth_clip_clamp.spec.ts#L82)
kainino0x
reviewed
Nov 30, 2021
Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
Contributor
Author
|
Thanks for the review! I addressed everything except the depth one. |
Contributor
Contributor
Contributor
|
Sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1610
Preview | Diff