[editorial] Detailed operations section with the rendering algorithm#1610
Merged
kvark merged 3 commits intogpuweb:mainfrom Apr 8, 2021
Merged
[editorial] Detailed operations section with the rendering algorithm#1610kvark merged 3 commits intogpuweb:mainfrom
kvark merged 3 commits intogpuweb:mainfrom
Conversation
kainino0x
approved these changes
Apr 8, 2021
Contributor
kainino0x
left a comment
There was a problem hiding this comment.
GitHub diff on this change is impossible to read, but I like the new structure so LGTM!
Contributor
Author
|
Given that reviewing it is hard, anyway, let's proceed. @toji if you want to read the changes, please check the "index resolution" and "compute operations" sections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The (growing) algorithm was buried in the description of
GPURenderPipelinecreation. I think there is a value in separating it from the API, given that it targets different audience. The API is read by users (who may use it as a reference) and implementors. But the detailed operations are read for building a set of expectations at a higher level about how operations are done. It's not expected to be read together with the API for object creation.I added a section after the APIs to be the new home for detailed operations.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Apr 8, 2021, 8:01 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.