Skip to content

Make maxBindingsPerBindGroup 1000 #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kainino0x merged 1 commit into from
Apr 28, 2023
Merged

Make maxBindingsPerBindGroup 1000 #2519

kainino0x merged 1 commit into from
Apr 28, 2023

Conversation

@takahirox
Copy link
Contributor

@takahirox takahirox commented Apr 27, 2023

To follow the WebGPU spec update
gpuweb/gpuweb#4050

Issue: #2517

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@takahirox
Make maxBindingsPerBindGroup 1000
851dd64 
To follow the WebGPU spec update
gpuweb/gpuweb#4050
@takahirox takahirox requested review from Kangz and kainino0x April 27, 2023 02:24
@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Previews, as seen when this build job started (851dd64):
Run tests | View tsdoc

kainino0x
kainino0x approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kainino0x kainino0x merged commit cf60692 into gpuweb:main Apr 28, 2023
@takahirox takahirox deleted the MaxBindingsPerBindGroup1000 branch April 28, 2023 05:06
ErichDonGubler pushed a commit to mozilla/gpuweb-cts that referenced this pull request Aug 16, 2023
@takahirox @ErichDonGubler
Make maxBindingsPerBindGroup 1000 (gpuweb#2519)
7f3d735 
To follow the WebGPU spec update
gpuweb/gpuweb#4050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kainino0x kainino0x kainino0x approved these changes

@Kangz Kangz Awaiting requested review from Kangz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@takahirox @kainino0x