-
-
Notifications
You must be signed in to change notification settings - Fork 217
Do not show 'All episodes' on podcast search #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ok, but are podcasts matching the query separated by the sections? |
|
No, the sections are not displayed if their title does not match the search string. |
|
Hiding |
|
Actually just hiding the 'All episodes' item during search would be fine for me, as then the first matching podcast is selected on the list. I'll change the PR accordingly. |
33be370 to
b5b217a
Compare
|
LGTM. But all-episodes remains selected for me. If a channel was selected before searching, the next channel or section after it does become selected if it gets hidden. What are your thoughts on resetting the channel/episode views if the search key is cleared with backspace? There is an option to always show find entries (which I don't use) and users must manually click the clear button or press Esc to reset the view. I'm not sure if that is a feature but it is confusing to me and this patch keeps all-episodes hidden when field is cleared with backspace. The following in both _filter_visible_func methods would reset channel and episode lists when their entry is cleared with backspace. |
|
The following resets channel/episode views when cleared with backspace, hides all-episodes when searching, and hides sections that don't have matched channels. I'm not sure why, but it seems to change selection from all-episodes to a channel or section. This does not fix the pre-existing #1023 found during testing. |
|
The patch above works fine and is a better solution to this. @auouymous, do you want to submit a separate PR, so I can close this one? |
Hide the "All episodes" channel proxy while performing a channel search. Replaces gpodder#1019. Hide sections that don't contain channels matching the query. Reset the channel or episode view when query is cleared with backspace. This is especially useful when "Always show Find entries" is enabled.
- hide the "All episodes" channel proxy while performing a channel search. - hide sections that don't contain channels matching the query. - reset the channel or episode view when query is cleared with backspace. Replaces #1019.
|
Replaced by #1030. |
Currently when searching podcasts, the 'All episodes' channel proxy and sections are always displayed on the results. This is confusing, since they do no match the search string.
This patch extends the keyword matching to PodcastChannelProxy titles, so they are only shown in search results when the title matches.
EDIT: This patch now just removes the 'All episodes' item from the podcast list during search.