feat: [#507] Add `Abort` method for Response by krishankumar01 · Pull Request #776 · goravel/framework

krishankumar01 · 2024-12-18T15:55:07Z

📑 Description

RelatedTo goravel/goravel#507

@coderabbitai summary

✅ Checks

Added test cases for my code

coderabbitai · 2024-12-18T15:55:18Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-12-18T16:00:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.76%. Comparing base (9b776be) to head (9441fe7).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #776   +/-   ##
=======================================
  Coverage   69.76%   69.76%           
=======================================
  Files         214      214           
  Lines       18337    18337           
=======================================
  Hits        12793    12793           
  Misses       4842     4842           
  Partials      702      702

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hwbrzzl · 2024-12-19T02:20:42Z

contracts/http/response.go


+type AbortResponse interface {
+	Response
+	Abort() error


Any concerns about not adding Abort to Response directly?

I decided not to implement the abort method for streaming, downloads, and other formats as it was unnecessary. Currently, it is implemented only for StringResponse and JsonResponse, which makes more sense to me.

I think Data and Redirect are needed, too.

…507

hwbrzzl · 2024-12-19T15:00:27Z

contracts/http/response.go


+type AbortResponse interface {
+	Response
+	Abort() error


I think Data and Redirect are needed, too.

contracts/http/response.go

…507

hwbrzzl

LGTM

This reverts commit be88582.

…782)" This reverts commit a6cfbad.

* Revert "Revert "feat: [#507] Add `Abort` method for Response (#776)" (#782)" This reverts commit a6cfbad. * rename `ResponseWithAbort` to `AbortableResponse` * chore: update mocks * remove unnecessary mocks --------- Co-authored-by: kkumar-gcc <kkumar-gcc@users.noreply.github.com>

add abort method

e457e9c

krishankumar01 requested a review from a team as a code owner December 18, 2024 15:55

chore: update mocks

15b207b

krishankumar01 closed this Dec 18, 2024

krishankumar01 reopened this Dec 18, 2024

krishankumar01 and others added 2 commits December 19, 2024 01:44

add abort method

be09972

chore: update mocks

e81ef98

krishankumar01 closed this Dec 18, 2024

krishankumar01 reopened this Dec 18, 2024

fix lint

7e2160c

hwbrzzl reviewed Dec 19, 2024

View reviewed changes

krishankumar01 and others added 3 commits December 19, 2024 13:15

Merge branch 'master' into kkumar-gcc/#507

5523d3e

.

81f5e4a

Merge remote-tracking branch 'origin/kkumar-gcc/#507' into kkumar-gcc/#…

1292394

…507

krishankumar01 closed this Dec 19, 2024

krishankumar01 reopened this Dec 19, 2024

chore: update mocks

089c7aa

hwbrzzl reviewed Dec 19, 2024

View reviewed changes

krishankumar01 and others added 4 commits December 19, 2024 20:57

rename abort response

2d11cc8

Merge remote-tracking branch 'origin/kkumar-gcc/#507' into kkumar-gcc/#…

bfba6a2

…507

Merge branch 'master' into kkumar-gcc/#507

c63cded

chore: update mocks

0f7a162

krishankumar01 closed this Dec 19, 2024

krishankumar01 reopened this Dec 19, 2024

hwbrzzl previously approved these changes Dec 20, 2024

View reviewed changes

krishankumar01 enabled auto-merge (squash) December 20, 2024 05:30

krishankumar01 disabled auto-merge December 20, 2024 05:30

Merge branch 'master' into kkumar-gcc/#507

be1677b

krishankumar01 dismissed hwbrzzl’s stale review via be1677b December 20, 2024 14:14

Merge branch 'master' into kkumar-gcc/#507

5a32176

krishankumar01 requested a review from hwbrzzl December 20, 2024 14:15

chore: update mocks

1f7ac95

krishankumar01 closed this Dec 20, 2024

krishankumar01 reopened this Dec 20, 2024

krishankumar01 requested a review from devhaozi December 21, 2024 07:08

hwbrzzl approved these changes Dec 21, 2024

View reviewed changes

Merge branch 'master' into kkumar-gcc/#507

9441fe7

krishankumar01 enabled auto-merge (squash) December 21, 2024 07:15

krishankumar01 merged commit be88582 into master Dec 21, 2024

krishankumar01 deleted the kkumar-gcc/#507 branch December 21, 2024 07:24

hwbrzzl added a commit that referenced this pull request Dec 23, 2024

Revert "feat: [#507] Add Abort method for Response (#776)"

57085e2

This reverts commit be88582.

hwbrzzl mentioned this pull request Dec 23, 2024

Revert "feat: [#507] Add Abort method for Response" #782

Merged

hwbrzzl added a commit that referenced this pull request Dec 23, 2024

Revert "feat: [#507] Add Abort method for Response (#776)" (#782)

a6cfbad

This reverts commit be88582.

krishankumar01 added a commit that referenced this pull request Dec 28, 2024

Revert "Revert "feat: [#507] Add Abort method for Response (#776)" (#…

dd7c6e4

…782)" This reverts commit a6cfbad.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [#507] Add `Abort` method for Response#776

feat: [#507] Add `Abort` method for Response#776
krishankumar01 merged 17 commits intomasterfrom
kkumar-gcc/#507

krishankumar01 commented Dec 18, 2024 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 18, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Dec 18, 2024 •

edited

Loading

Uh oh!

hwbrzzl Dec 19, 2024

Uh oh!

krishankumar01 Dec 19, 2024

Uh oh!

hwbrzzl Dec 19, 2024

Uh oh!

hwbrzzl Dec 19, 2024

Uh oh!

Uh oh!

hwbrzzl left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

krishankumar01 commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

✅ Checks

Uh oh!

coderabbitai bot commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hwbrzzl Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

krishankumar01 Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

krishankumar01 commented Dec 18, 2024 •

edited

Loading

coderabbitai bot commented Dec 18, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Dec 18, 2024 •

edited

Loading