Skip to content

fix: translation issue#507

Merged
hwbrzzl merged 1 commit intov1.14.xfrom
bowen/fix-translation
Jun 12, 2024
Merged

fix: translation issue#507
hwbrzzl merged 1 commit intov1.14.xfrom
bowen/fix-translation

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Jun 12, 2024

📑 Description

There is an issue when calling facades.Lang().SetLocale in middle, facades.Lang().CurrentLocale() still returns the default locale in controller.

✅ Checks

  • Added test cases for my code

@codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (0e492c6) to head (d805a32).

Additional details and impacted files 
@@           Coverage Diff            @@
##           v1.14.x     #507   +/-   ##
========================================
  Coverage    70.03%   70.04%           
========================================
  Files          176      176           
  Lines        10877    10876    -1     
========================================
  Hits          7618     7618           
+ Misses        2691     2690    -1     
  Partials       568      568

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krishankumar01
krishankumar01 previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@krishankumar01 krishankumar01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl changed the base branch from master to v1.14.x June 12, 2024 09:52
@hwbrzzl hwbrzzl dismissed krishankumar01’s stale review June 12, 2024 09:52

The base branch was changed.

@hwbrzzl hwbrzzl force-pushed the bowen/fix-translation branch from 02862a1 to d805a32 Compare June 12, 2024 09:59
@hwbrzzl hwbrzzl merged commit ab2d51e into v1.14.x Jun 12, 2024
@hwbrzzl hwbrzzl deleted the bowen/fix-translation branch June 12, 2024 12:13
hwbrzzl added a commit that referenced this pull request Jun 14, 2024
@hwbrzzl
merge: v1.14.1 (#512)
7ae41c1 
* fix translation (#507)

* fix: a session middleware issue (#508)

* fix: lang path (#510)

* fix: lang path issue

* remove

* add golang 1.22

* release: v1.14.1
krishankumar01 added a commit that referenced this pull request Dec 19, 2024
@krishankumar01
Merge branch 'master' into kkumar-gcc/#507
5523d3e
krishankumar01 added a commit that referenced this pull request Dec 19, 2024
@krishankumar01
Merge remote-tracking branch 'origin/kkumar-gcc/#507' into kkumar-gcc/#…
1292394 
…507
krishankumar01 added a commit that referenced this pull request Dec 19, 2024
@krishankumar01
Merge remote-tracking branch 'origin/kkumar-gcc/#507' into kkumar-gcc/#…
bfba6a2 
…507
krishankumar01 added a commit that referenced this pull request Dec 19, 2024
@krishankumar01
Merge branch 'master' into kkumar-gcc/#507
c63cded
krishankumar01 added a commit that referenced this pull request Dec 20, 2024
@krishankumar01
Merge branch 'master' into kkumar-gcc/#507
be1677b
krishankumar01 added a commit that referenced this pull request Dec 20, 2024
@krishankumar01
Merge branch 'master' into kkumar-gcc/#507
5a32176
krishankumar01 added a commit that referenced this pull request Dec 21, 2024
@krishankumar01
Merge branch 'master' into kkumar-gcc/#507
9441fe7
krishankumar01 added a commit that referenced this pull request Dec 21, 2024
@krishankumar01
feat: [#507] Add Abort method for Response (#776)
be88582 
* add abort method

* chore: update mocks

* add abort method

* chore: update mocks

* fix lint

* .

* chore: update mocks

* rename abort response

* chore: update mocks

* chore: update mocks

---------

Co-authored-by: kkumar-gcc <kkumar-gcc@users.noreply.github.com>
hwbrzzl added a commit that referenced this pull request Dec 23, 2024
@hwbrzzl
Revert "feat: [#507] Add Abort method for Response (#776)"
57085e2 
This reverts commit be88582.
hwbrzzl added a commit that referenced this pull request Dec 23, 2024
@hwbrzzl
Revert "feat: [#507] Add Abort method for Response (#776)" (#782)
a6cfbad 
This reverts commit be88582.
krishankumar01 added a commit that referenced this pull request Dec 28, 2024
@krishankumar01
Revert "Revert "feat: [#507] Add Abort method for Response (#776)" (#…
dd7c6e4 
…782)"

This reverts commit a6cfbad.
krishankumar01 added a commit that referenced this pull request Dec 29, 2024
@krishankumar01
Merge branch 'master' into revert-782-revert-776-kkumar-gcc/#507
8bf96f3
krishankumar01 added a commit that referenced this pull request Dec 29, 2024
@krishankumar01
Merge remote-tracking branch 'origin/revert-782-revert-776-kkumar-gcc/#…
b070dcc 
…507' into revert-782-revert-776-kkumar-gcc/#507
krishankumar01 added a commit that referenced this pull request Dec 29, 2024
@krishankumar01
feat: [#507] Add Abort method for Response (#795)
7de6cc0 
* Revert "Revert "feat: [#507] Add `Abort` method for Response (#776)" (#782)"

This reverts commit a6cfbad.

* rename `ResponseWithAbort` to `AbortableResponse`

* chore: update mocks

* remove unnecessary mocks

---------

Co-authored-by: kkumar-gcc <kkumar-gcc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krishankumar01 krishankumar01 krishankumar01 left review comments

Assignees

No one assigned

Labels

🚀 Review Ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hwbrzzl @krishankumar01