Add DELETE support in V3 volume types#655
Conversation
5ab4889 to
83d60f6
Compare
|
Build succeeded.
|
83d60f6 to
ca7cc3d
Compare
|
Build succeeded.
|
Add Create/Delete/List/Update/Get support for volume type in volume V3.
ca7cc3d to
d36378d
Compare
|
Build succeeded.
|
dklyle
left a comment
There was a problem hiding this comment.
Just one minor item. Otherwise, this looks good to me.
| } | ||
|
|
||
| func TestVolumeTypesCreate(t *testing.T) { | ||
| func TestVolumeTypesCreateDestory(t *testing.T) { |
There was a problem hiding this comment.
just a nit, but Destroy is misspelled, but to be consistent I would just change it to TestVolumeTypesCRUD.
Support volume type delete in V3
d36378d to
3798066
Compare
|
@dklyle done! |
|
Build succeeded.
|
jtopjian
left a comment
There was a problem hiding this comment.
@TommyLike three small changes that can wait until the next PR.
This looks good to me, pending @dklyle's approval, too.
| } | ||
| fmt.Println(volumeType) | ||
|
|
||
| Example to delete a Volume TYpe |
There was a problem hiding this comment.
nit: TYpe should be Type, but this can be fixed in the next PR.
| } | ||
|
|
||
| func TestVolumeTypesCreate(t *testing.T) { | ||
| func TestVolumeTypesCreateDestroy(t *testing.T) { |
There was a problem hiding this comment.
Assuming you're going to do the Update test here, too, please change to TestVolumeTypesCRUD in the next PR.
|
|
||
| Example to delete a Volume TYpe | ||
|
|
||
| typeID := "0fe36e73809d46aeae6705c39077b1b3" |
There was a problem hiding this comment.
nit: this is supposed to be a UUID such as ca33f1fa-3ff5-42d8-a8a8-4417ae2e9130
| } | ||
| } | ||
|
|
||
| func TestVolumeTypesCreate(t *testing.T) { |
|
@TommyLike Thanks for this. If you can patch up the doc nits in the Update PR, it would be appreciated. Also, for posterity, the Cinder code for this is here: https://github.com/openstack/cinder/blob/stable/pike/cinder/api/contrib/types_manage.py#L164 @TommyLike Please remember to link to the source code for all PRs. |
|
Also, @dklyle, thank you for reviewing. |
…cloud#655) * Add new data source 'openstack_compute_availability_zones_v2' * Fix up TOC * Add region to schema * Fix up error messaging * Simplify test * Style fixes * Fix up style issues * Fix up another style issue * Use Default in 'state' Schema * Make region computed, set region when state is read * Sort list of zones * Use the hashcode library to create the state's ID from the list of zones * Documentation updates
Add Delete support for volume type in volume V3.
For #649
Volume type delete V3