Support volume type delete in V3

TommyLike · TommyLike · commit d36378dae6cf · 2017-12-20T16:58:20.000+08:00
diff --git a/acceptance/openstack/blockstorage/v3/volumetypes_test.go b/acceptance/openstack/blockstorage/v3/volumetypes_test.go
@@ -45,7 +45,7 @@ func TestVolumeTypesList(t *testing.T) {
 	}
 }
 
-func TestVolumeTypesCreate(t *testing.T) {
+func TestVolumeTypesCreateDestory(t *testing.T) {
 	client, err := clients.NewBlockStorageV3Client()
 	if err != nil {
 		t.Fatalf("Unable to create a blockstorage client: %v", err)
@@ -64,4 +64,6 @@ func TestVolumeTypesCreate(t *testing.T) {
 	}
 
 	tools.PrintResource(t, vt)
+
+	defer volumetypes.Delete(client, vt.ID)
 }
diff --git a/openstack/blockstorage/v3/volumetypes/doc.go b/openstack/blockstorage/v3/volumetypes/doc.go
@@ -37,6 +37,14 @@ Example to create a Volume Type
 		panic(err)
 	}
 	fmt.Println(volumeType)
+
+Example to delete a Volume TYpe
+
+	typeID := "0fe36e73809d46aeae6705c39077b1b3"
+	err := volumetypes.Delete(client, typeID).ExtractErr()
+	if err != nil{
+		panic(err)
+	}
 */
 
 package volumetypes
diff --git a/openstack/blockstorage/v3/volumetypes/testing/requests_test.go b/openstack/blockstorage/v3/volumetypes/testing/requests_test.go
@@ -80,7 +80,6 @@ func TestCreate(t *testing.T) {
 	th.AssertEquals(t, n.PublicAccess, true)
 	th.AssertEquals(t, n.ID, "6d0ff92a-0007-4780-9ece-acfe5876966a")
 	th.AssertEquals(t, n.ExtraSpecs["capabilities"], "gpu")
-	th.AssertEquals(t, n.ID, "6d0ff92a-0007-4780-9ece-acfe5876966a")
 }
 
 func TestDelete(t *testing.T) {
diff --git a/openstack/blockstorage/v3/volumetypes/urls.go b/openstack/blockstorage/v3/volumetypes/urls.go
@@ -17,4 +17,3 @@ func createURL(c *gophercloud.ServiceClient) string {
 func deleteURL(c *gophercloud.ServiceClient, id string) string {
 	return c.ServiceURL("types", id)
 }
-

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ func TestVolumeTypesList(t *testing.T) {`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`
`48`		`-func TestVolumeTypesCreate(t *testing.T) {`
	`48`	`+func TestVolumeTypesCreateDestory(t *testing.T) {`
`49`	`49`	`client, err := clients.NewBlockStorageV3Client()`
`50`	`50`	`if err != nil {`
`51`	`51`	`t.Fatalf("Unable to create a blockstorage client: %v", err)`
`@@ -64,4 +64,6 @@ func TestVolumeTypesCreate(t *testing.T) {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`tools.PrintResource(t, vt)`
	`67`	`+`
	`68`	`+ defer volumetypes.Delete(client, vt.ID)`
`67`	`69`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ func TestCreate(t *testing.T) {`
`80`	`80`	`th.AssertEquals(t, n.PublicAccess, true)`
`81`	`81`	`th.AssertEquals(t, n.ID, "6d0ff92a-0007-4780-9ece-acfe5876966a")`
`82`	`82`	`th.AssertEquals(t, n.ExtraSpecs["capabilities"], "gpu")`
`83`		`- th.AssertEquals(t, n.ID, "6d0ff92a-0007-4780-9ece-acfe5876966a")`
`84`	`83`	`}`
`85`	`84`
`86`	`85`	`func TestDelete(t *testing.T) {`
Original file line number	Diff line number	Diff line change
`@@ -17,4 +17,3 @@ func createURL(c *gophercloud.ServiceClient) string {`
`17`	`17`	`func deleteURL(c *gophercloud.ServiceClient, id string) string {`
`18`	`18`	`return c.ServiceURL("types", id)`
`19`	`19`	`}`
`20`		`-`