blockstorage: add manage-existing and unmanage api call#3332
Merged
stephenfin merged 3 commits intogophercloud:mainfrom May 23, 2025
Merged
blockstorage: add manage-existing and unmanage api call#3332stephenfin merged 3 commits intogophercloud:mainfrom
stephenfin merged 3 commits intogophercloud:mainfrom
Conversation
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
cd71982 to
8477643
Compare
Implemented missing blockstorage api call to manage existing volume. ref. https://docs.openstack.org/api-ref/block-storage/v3/#manage-an-existing-volume
Implemented missing blockstorage api call to unmanage volume. ref. https://docs.openstack.org/api-ref/block-storage/v3/#unmanage-a-volume
Added acceptance test for managing a existing volume and unmanaging a volume api calls.
8477643 to
6fb7d11
Compare
Contributor
Author
|
Any problems? If there are things to be fixed, I'd like to know. |
Contributor
|
There is no problem at all, sorry for the time it takes. The team has been very busy lately. We'll wait to see how CI works here and we'll make a review in a timely manner. |
Contributor
Author
|
Thank you for responding! I'm very appreciative for your team's development despite busy schedule. |
|
Hey @EmilienM would be great if this gets merged, I'm working on something which relies on Cinder Manage. |
stephenfin
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice to meet you. I always appreciate your developments.
I have this pull request ready to do, so could you please review it?
I implemented a missing blockstorage API call to manage an existing volume and unmanage a volume.
API document for the endpoints are these:
I wrote the unit and acceptance tests and checked that they worked.
Therefore, I tested the new code with the environment and the script below.
And it worked.
Fixes #3324
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API doc
source code