Add support for zone sharing in DNS v2#3286
Conversation
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
mandre
left a comment
There was a problem hiding this comment.
Thanks for the PR. Could you add acceptance tests? This is important to verify that the feature works against real live environments.
|
It looks like go-apidiff picked up the changes from #3284 and now marks your PR as non-backward compatible. That would be a problem with our automation, and I suspect that we'll get the expected semver label if you rebase on main. Could you do that? |
This commit introduces functionality to share and unshare DNS zones with other projects using the OpenStack DNS v2 API. The following changes are included: - Added `Share` and `Unshare` methods in `requests.go` to handle API calls. - Updated `results.go` to include parsing for share/unshare responses. - Enhanced `urls.go` to generate proper URLs for share-related operations. - Created unit tests in `requests_test.go` to validate `Share` and `Unshare`. These additions allow users to manage shared zones programmatically and align Gophercloud with the DNS v2 API capabilities.
fd6d1cb to
05687fb
Compare
|
@mandre Cheers for spotting that! Rebased. |
This commit introduces functionality to share and unshare DNS zones with other projects using the OpenStack DNS v2 API. The following changes are included:
ShareandUnsharemethods inrequests.goto handle API calls.results.goto include parsing for share/unshare responses.urls.goto generate proper URLs for share-related operations.requests_test.goto validateShareandUnshare.These additions allow users to manage shared zones programmatically and align Gophercloud with the DNS v2 API capabilities.
Fixes #3048
Links to the line numbers/files in the OpenStack source code that support the code in this PR: