block_storage: get quotausage for blockstorage volume_types#3284
Merged
mandre merged 2 commits intogophercloud:mainfrom Feb 4, 2025
Merged
block_storage: get quotausage for blockstorage volume_types#3284mandre merged 2 commits intogophercloud:mainfrom
mandre merged 2 commits intogophercloud:mainfrom
Conversation
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
Contributor
Author
|
@mandre - sorry for that, was missing a comma in the test fixture for the v2 block storage schema, which caused the test to fail. Should be all good now. |
mandre
approved these changes
Feb 4, 2025
Contributor
mandre
left a comment
There was a problem hiding this comment.
Thanks, LGTM.
We won't be able to backport this to branch v2 however, due to the backward incompatible change:
Incompatible changes:
- QuotaUsageSet: old is comparable, new is not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The volume_type attributes are currently only set for QuotaSet objects.
Hence, implemented per
volume_typeQuotaUsage as a nested objectof
QuotaUsageSetfor block storage.See API docs for refs.
block-storage v3
https://docs.openstack.org/api-ref/block-storage/v3/#show-quota-usage-for-a-project
block-storage v2
https://docs.openstack.org/api-ref/block-storage/v2/#show-quotas