loadbalancer additional_vips #2699#2700
Closed
snigle wants to merge 3 commits intogophercloud:masterfrom
Closed
Conversation
d0da563 to
ec22e01
Compare
EmilienM
reviewed
Jul 19, 2023
EmilienM
reviewed
Jul 19, 2023
EmilienM
reviewed
Jul 19, 2023
EmilienM
reviewed
Jul 19, 2023
openstack/loadbalancer/v2/loadbalancers/testing/requests_test.go
Outdated
Show resolved
Hide resolved
EmilienM
requested changes
Jul 19, 2023
Contributor
EmilienM
left a comment
There was a problem hiding this comment.
Please also add testing coverage in acceptance. Thanks!
ec22e01 to
966fd27
Compare
Contributor
Author
tried to write them but I don't have environment to execute it |
Contributor
Author
|
tested on my production environment and works. I don't understand why acceptances fails in github |
Contributor
|
CI seems unhappy now with |
Contributor
|
Could you please rebase, so it'll trigger CI again and if green I'll merge it. |
|
@snigle any chance you can finish it up? |
Contributor
|
@dulek Any thoughts on this? |
Contributor
|
It looks good to me from the functional standpoint. |
Contributor
|
please rebase, it'll trigger proper CI jobs. Thanks ! |
Contributor
|
taken care here: #2866 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2699
https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=show-load-balancer-details-detail#show-load-balancer-details