loadbalancer additional_vips acceptance tests

Ludovic Lamarche · Ludovic Lamarche · commit 966fd275ebc2 · 2023-07-19T14:03:34.000Z
diff --git a/acceptance/openstack/loadbalancer/v2/loadbalancer.go b/acceptance/openstack/loadbalancer/v2/loadbalancer.go
@@ -110,17 +110,18 @@ func CreateListenerHTTP(t *testing.T, client *gophercloud.ServiceClient, lb *loa
 
 // CreateLoadBalancer will create a load balancer with a random name on a given
 // subnet. An error will be returned if the loadbalancer could not be created.
-func CreateLoadBalancer(t *testing.T, client *gophercloud.ServiceClient, subnetID string, tags []string, policyID string) (*loadbalancers.LoadBalancer, error) {
+func CreateLoadBalancer(t *testing.T, client *gophercloud.ServiceClient, subnetID string, tags []string, policyID string, additionalVips []loadbalancers.AdditionalVip) (*loadbalancers.LoadBalancer, error) {
 	lbName := tools.RandomString("TESTACCT-", 8)
 	lbDescription := tools.RandomString("TESTACCT-DESC-", 8)
 
 	t.Logf("Attempting to create loadbalancer %s on subnet %s", lbName, subnetID)
 
 	createOpts := loadbalancers.CreateOpts{
-		Name:         lbName,
-		Description:  lbDescription,
-		VipSubnetID:  subnetID,
-		AdminStateUp: gophercloud.Enabled,
+		Name:           lbName,
+		Description:    lbDescription,
+		VipSubnetID:    subnetID,
+		AdminStateUp:   gophercloud.Enabled,
+		AdditionalVips: additionalVips,
 	}
 	if len(tags) > 0 {
 		createOpts.Tags = tags
diff --git a/acceptance/openstack/loadbalancer/v2/loadbalancers_test.go b/acceptance/openstack/loadbalancer/v2/loadbalancers_test.go
@@ -51,7 +51,7 @@ func TestLoadbalancersListByTags(t *testing.T) {
 	// Add "test" tag intentionally to test the "not-tags" parameter. Because "test" tag is also used in other test
 	// cases, we use "test" tag to exclude load balancers created by other test case.
 	tags := []string{"tag1", "tag2", "test"}
-	lb, err := CreateLoadBalancer(t, lbClient, subnet.ID, tags, "")
+	lb, err := CreateLoadBalancer(t, lbClient, subnet.ID, tags, "", nil)
 	th.AssertNoErr(t, err)
 	defer DeleteLoadBalancer(t, lbClient, lb.ID)
 
@@ -111,7 +111,7 @@ func TestLoadbalancerHTTPCRUD(t *testing.T) {
 	th.AssertNoErr(t, err)
 	defer networking.DeleteSubnet(t, netClient, subnet.ID)
 
-	lb, err := CreateLoadBalancer(t, lbClient, subnet.ID, nil, "")
+	lb, err := CreateLoadBalancer(t, lbClient, subnet.ID, nil, "", nil)
 	th.AssertNoErr(t, err)
 	defer DeleteLoadBalancer(t, lbClient, lb.ID)
 
@@ -257,14 +257,25 @@ func TestLoadbalancersCRUD(t *testing.T) {
 	th.AssertNoErr(t, err)
 	defer networking.DeleteSubnet(t, netClient, subnet.ID)
 
+	additionalSubnet, err := networking.CreateSubnet(t, netClient, network.ID)
+	th.AssertNoErr(t, err)
+	defer networking.DeleteSubnet(t, netClient, additionalSubnet.ID)
+
+	additionalSubnetPort, err := networking.CreatePort(t, netClient, network.ID, additionalSubnet.ID)
+	th.AssertNoErr(t, err)
+	defer networking.DeletePort(t, netClient, additionalSubnetPort.ID)
+
 	policy1, err := policies.CreateQoSPolicy(t, netClient)
 	th.AssertNoErr(t, err)
 	defer policies.DeleteQoSPolicy(t, netClient, policy1.ID)
 
 	tags := []string{"test"}
-	lb, err := CreateLoadBalancer(t, lbClient, subnet.ID, tags, policy1.ID)
+	lb, err := CreateLoadBalancer(t, lbClient, subnet.ID, tags, policy1.ID, []loadbalancers.AdditionalVip{{SubnetID: additionalSubnet.ID, IPAddress: additionalSubnetPort.FixedIPs[0].IPAddress}})
 	th.AssertNoErr(t, err)
 	th.AssertEquals(t, lb.VipQosPolicyID, policy1.ID)
+	th.AssertEquals(t, 1, len(lb.AdditionalVips))
+	th.AssertEquals(t, additionalSubnetPort.FixedIPs[0].IPAddress, lb.AdditionalVips[0].IPAddress)
+	th.AssertEquals(t, additionalSubnetPort.FixedIPs[0].SubnetID, lb.AdditionalVips[0].SubnetID)
 	defer DeleteLoadBalancer(t, lbClient, lb.ID)
 
 	lbDescription := ""
@@ -463,7 +474,7 @@ func TestLoadbalancersCascadeCRUD(t *testing.T) {
 	defer networking.DeleteSubnet(t, netClient, subnet.ID)
 
 	tags := []string{"test"}
-	lb, err := CreateLoadBalancer(t, lbClient, subnet.ID, tags, "")
+	lb, err := CreateLoadBalancer(t, lbClient, subnet.ID, tags, "", nil)
 	th.AssertNoErr(t, err)
 	defer CascadeDeleteLoadBalancer(t, lbClient, lb.ID)
 
