loadbalancer additional_vips by snigle#2866
Merged
Conversation
9a96aa5 to
b25d38a
Compare
EmilienM
commented
Jan 16, 2024
internal/acceptance/openstack/loadbalancer/v2/loadbalancers_test.go
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Now e2e fails because https://github.com/openstack/octavia/blob/5750e4512d622450f6ecab1c7001ebd5637e0d53/api-ref/source/parameters.yaml#L138-L148 : we need microversion 2.26 at minimum. |
49bd786 to
15830c2
Compare
The additional VIPs should not be created before the load balancer, Octavia already takes care of creating the port for us. Also, this feature is only available in Zed and beyond.
15830c2 to
eeda2a2
Compare
Contributor
|
/lgtm |
Contributor
Author
|
@pierreprinetti any chance to look at it when time permits? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially started with #2700 by @snigle - but we have tried to reach the author with no success, and some folks needs this PR.
To get it, we just need it rebased.
Fixes #2699
https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=show-load-balancer-details-detail#show-load-balancer-details