Skip to content

core: keep keystone reauth error on failed reauth#2259

Merged
EmilienM merged 1 commit intogophercloud:masterfrom
kayrus:reauth-err
Nov 5, 2021
Merged

core: keep keystone reauth error on failed reauth#2259
EmilienM merged 1 commit intogophercloud:masterfrom
kayrus:reauth-err

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Nov 4, 2021

resolves #2258

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0008%) to 79.862% when pulling 082da41 on kayrus:reauth-err into 492ab2c on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Nov 4, 2021

Build failed.

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Nov 5, 2021

LGTM, thanks!

@EmilienM EmilienM merged commit 3889f57 into gophercloud:master Nov 5, 2021
@kayrus kayrus deleted the reauth-err branch November 5, 2021 07:06
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Nov 5, 2021

@EmilienM
The following tests failed:

  • TestTrunk*
  • TestStacks*

would you like to add skip flag for these tests?

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Nov 5, 2021

@EmilienM The following tests failed:

* TestTrunk*

* TestStacks*

would you like to add skip flag for these tests?

yes I'm working on restoring acceptance job into a good shape, here: #2252

I'll fix them up.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Nov 5, 2021

One thing to keep in mind is that acceptance tests were passing less than 2 weeks ago (#2238, #2243). Either the issues are with the testing environment configuration or a recent upstream change.

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Nov 8, 2021

One thing to keep in mind is that acceptance tests were passing less than 2 weeks ago (#2238, #2243). Either the issues are with the testing environment configuration or a recent upstream change.

yeah I tried to figure this out today and couldn't find the culprit. Did a bunch of investigations between jobs, like package diffs (APT + pip), etc. It would take more time to figure this out. I'll see what I can do.
The thing I need to figure first is why we don't have any Heat logs when a stack tries to get created. I'll fix logs first then investigate the actual failures.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Nov 9, 2021

@EmilienM I apologies for not creating a new issue, but I noticed that you don't update the https://github.com/gophercloud/gophercloud/blob/master/CHANGELOG.md after the PR is merged. I'd appreciate if you start maintaining this file. Thanks in advance.

@EmilienM
Copy link
Copy Markdown
Contributor

@EmilienM I apologies for not creating a new issue, but I noticed that you don't update the https://github.com/gophercloud/gophercloud/blob/master/CHANGELOG.md after the PR is merged. I'd appreciate if you start maintaining this file. Thanks in advance.

yeah it's on my list

@EmilienM
Copy link
Copy Markdown
Contributor

#2264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Core: reauthentication error is not reflected in original error

4 participants