Fix openstack/common/extension doc examples#2243
Merged
jtopjian merged 2 commits intogophercloud:masterfrom Oct 25, 2021
Merged
Fix openstack/common/extension doc examples#2243jtopjian merged 2 commits intogophercloud:masterfrom
jtopjian merged 2 commits intogophercloud:masterfrom
Conversation
The doc example for `openstack/common/extension` would otherwise fail
compilation with:
extensions.List(networkClient).Allpages undefined (type pagination.Pager has no field or method Allpages, but does have AllPages)
Some doc examples were wrongly calling `fmt.Println()` with a formatting
specifier instead of `fmt.Printf()`. This caused the examples to print
the literal string `%+v` with a new line before printing the argument
using its default format. This clears the following compilation warning:
Println call has possible formatting directive %+v
Got all files with `ag "Println.+%"`.
Member
|
LGTM! 👍 |
|
Build succeeded.
|
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix calls to pagination.Pager.AllPages() in
openstack/common/extensiondoc examples and also fix formatting error withfmt.Println().For #2242