Add List and Get method for bgp/speakers#2238
Merged
jtopjian merged 2 commits intogophercloud:masterfrom Oct 23, 2021
Merged
Conversation
|
Build succeeded.
|
Contributor
|
@shhgs It looks like https://github.com/gophercloud/gophercloud/runs/3953332128?check_suite_focus=true If it's possible for your editor to automatically run |
Contributor
Author
|
Interesting. Can you please give me the gofmt version on your system? I have double checked. On my system, [CL-DESKTOP] 03:44:36 ~/src/github.com/shhgs/gophercloud $ git diff --name-only official/master | while read f; do diff -u $f <(gofmt $f); done
✔ ~/src/github.com/shhgs/gophercloud [20211020|✔ ]
[CL-DESKTOP] 03:44:38 ~/src/github.com/shhgs/gophercloud $ And if I manually take the advice from CI/CD, [CL-DESKTOP] 03:48:45 ~/src/github.com/shhgs/gophercloud $ git diff
diff --git a/openstack/networking/v2/extensions/bgp/speakers/testing/requests_test.go b/openstack/networking/v2/extensions/bgp/speakers/testing/requests_test.go
index 3bd335de..4f257302 100644
--- a/openstack/networking/v2/extensions/bgp/speakers/testing/requests_test.go
+++ b/openstack/networking/v2/extensions/bgp/speakers/testing/requests_test.go
@@ -2,12 +2,13 @@ package testing
import (
"fmt"
+ "net/http"
+ "testing"
+
fake "github.com/gophercloud/gophercloud/openstack/networking/v2/common"
"github.com/gophercloud/gophercloud/openstack/networking/v2/extensions/bgp/speakers"
"github.com/gophercloud/gophercloud/pagination"
th "github.com/gophercloud/gophercloud/testhelper"
- "net/http"
- "testing"
)
func TestList(t *testing.T) {
✔ ~/src/github.com/shhgs/gophercloud [20211020|✚ 1]
[CL-DESKTOP] 03:48:49 ~/src/github.com/shhgs/gophercloud $ git diff --name-only official/master | while read f; do diff -u $f <(gofmt $f); done
✔ ~/src/github.com/shhgs/gophercloud [20211020|✚ 1]
[CL-DESKTOP] 03:48:56 ~/src/github.com/shhgs/gophercloud $ |
Contributor
|
@shhgs It looks like the CI job is using Go 1.15: https://github.com/gophercloud/gophercloud/blob/master/.github/workflows/unit.yml#L10 |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: Neutron V2: BGP Dynamic Routing #2208
https://github.com/shhgs/gophercloud/tree/20211020