Merged
Conversation
…wall_policy_id According https://github.com/openstack/neutron-fwaas/blob/stable/ussuri/neutron_fwaas/db/firewall/v2/firewall_db_v2.py#L609 openstack does return an array here. The docs tell it is a string.
|
Build succeeded.
|
Contributor
Author
|
here is the output of acceptance/openstack/networking/v2/extensions/fwaas_v2/policy_test.go |
|
Build succeeded.
|
|
Build succeeded.
|
172648c to
4ca3e93
Compare
|
Build succeeded.
|
Contributor
Author
|
@Elethiomel @jtopjian ptal :-) |
jtopjian
requested changes
Dec 2, 2020
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
@codemanufaktur Thank you for working on this and for the test output 🙂
I've left a few comments - mostly just renaming fields. Please let me know if you have any questions.
openstack/networking/v2/extensions/fwaas_v2/policies/requests.go
Outdated
Show resolved
Hide resolved
| DestinationPort string `json:"destination_port,omitempty"` | ||
| Shared bool `json:"shared,omitempty"` | ||
| Enabled bool `json:"enabled,omitempty"` | ||
| FirewallPolicyID []string `json:"firewall_policy_id"` |
Contributor
There was a problem hiding this comment.
Should this have always been []string or was this a change made between OpenStack releases?
Contributor
There was a problem hiding this comment.
Hi @jtopjian , if I did see it right, then firewall_policy_id was introduced as array:
See commit: openstack/neutron-fwaas@55fed40
Also here the reference to the neutron-fwaas codebase: https://github.com/openstack/neutron-fwaas/blob/stable/ussuri/neutron_fwaas/db/firewall/v2/firewall_db_v2.py#L282
openstack/networking/v2/extensions/fwaas_v2/policies/requests.go
Outdated
Show resolved
Hide resolved
openstack/networking/v2/extensions/fwaas_v2/policies/requests.go
Outdated
Show resolved
Hide resolved
openstack/networking/v2/extensions/fwaas_v2/policies/requests.go
Outdated
Show resolved
Hide resolved
openstack/networking/v2/extensions/fwaas_v2/policies/requests.go
Outdated
Show resolved
Hide resolved
schreibergeorg
added a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Dec 8, 2020
schreibergeorg
added a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Dec 8, 2020
f728a02 to
84c3fb8
Compare
schreibergeorg
added a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Dec 8, 2020
84c3fb8 to
a84938a
Compare
a84938a to
ec15a46
Compare
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up PR for #1789 by @Elethiomel (I asked for the permission to get this done)
contains 2 cherry-picks from https://github.com/Daimler/gophercloud/commits/fwaas-v2 by @chrischdi
For #514
https://github.com/openstack/neutron-lib/blob/56033ba643812a30577f6ab17648806c2ee494ba/neutron_lib/api/definitions/firewall_v2.py#L159
https://github.com/openstack/neutron-fwaas/blob/27906d0acff349c9e5ac7955d203fb2233c295db/neutron_fwaas/db/firewall/v2/firewall_db_v2.py#L148
Georg Schreiber georg.g.schreiber@daimler.com, Daimler TSS GmbH, legal info/Impressum