[WIP] FWaaSv2.0 Policy CRUD#1789
Closed
Elethiomel wants to merge 4 commits intogophercloud:masterfrom
Closed
Conversation
|
Build succeeded.
|
Contributor
Author
|
@jtopjian Here's the entire Policy CRUD one for you :) |
jtopjian
requested changes
Dec 4, 2019
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
@Elethiomel Nice work. Overall this is good.
I've left a few comments to review. In addition, we also need a doc.go file with examples on how to use the functions.
Please let me know if you have any questions.
| Description *string `json:"description,omitempty"` | ||
| Shared *bool `json:"shared,omitempty"` | ||
| Audited *bool `json:"audited,omitempty"` | ||
| Rules []string `json:"firewall_rules,omitempty"` |
Contributor
There was a problem hiding this comment.
Is it possible to remove all rules from a policy? If so, this might need to be changed to *[]string{}. If this is possible to do, we should include an acceptance test and check that the returned policy's rules length is 0.
Contributor
There was a problem hiding this comment.
fixed with mercedes-benz@7efe16b, but the acceptance test is probably missing. will check this on #2057
|
Build succeeded.
|
|
Build failed.
|
|
Build succeeded.
|
Contributor
|
Hi @Elethiomel are you still into this? |
Contributor
Author
|
Yes I hope to progress on it soon. I've had some other major projects in the way unfortunately |
chrischdi
pushed a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Sep 25, 2020
chrischdi
pushed a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Sep 25, 2020
chrischdi
pushed a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Sep 25, 2020
schreibergeorg
pushed a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Nov 13, 2020
schreibergeorg
pushed a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Nov 13, 2020
schreibergeorg
pushed a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Nov 13, 2020
schreibergeorg
pushed a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Nov 13, 2020
schreibergeorg
added a commit
to mercedes-benz/gophercloud
that referenced
this pull request
Nov 16, 2020
jtopjian
pushed a commit
that referenced
this pull request
Dec 9, 2020
* FWaaSv2.0 Policy * s/Router/Policy/g as per #1789 (comment) * Acceptance test for AddRule as per #1789 (comment) * Acceptance test for RemoveRule as per #1789 (comment) * fwaas_v2: review fix (#1789 (comment)) from #1789 * openstack/networking/v2/extensions/fwaas_v2/rules/results.go fix firewall_policy_id According https://github.com/openstack/neutron-fwaas/blob/stable/ussuri/neutron_fwaas/db/firewall/v2/firewall_db_v2.py#L609 openstack does return an array here. The docs tell it is a string. * fix goimports * fwaas_v2: testing to remove all rules from firewall policy (#1789 (comment)) * fwaas_v2: extract result & test for policies.AddRule * fwaas_v2: test for RemoveRule * apply suggestions from #2057 Co-authored-by: Colin Fowler <elethiomel@gmail.com> Co-authored-by: Colin Fowler <colin.fowler@yoti.com> Co-authored-by: Schlotter, Christian <christian.schlotter@daimler.com>
Contributor
|
@Elethiomel #2057 is merged, I think you can close this one. Thank you :-) |
Contributor
|
Thank you both for your work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #514
https://github.com/openstack/neutron-lib/blob/56033ba643812a30577f6ab17648806c2ee494ba/neutron_lib/api/definitions/firewall_v2.py#L159
https://github.com/openstack/neutron-fwaas/blob/27906d0acff349c9e5ac7955d203fb2233c295db/neutron_fwaas/db/firewall/v2/firewall_db_v2.py#L148