Fwaasv2 update delete firewall groups (depends on #2048)#2049
Closed
schreibergeorg wants to merge 3 commits intogophercloud:masterfrom
Closed
Fwaasv2 update delete firewall groups (depends on #2048)#2049schreibergeorg wants to merge 3 commits intogophercloud:masterfrom
schreibergeorg wants to merge 3 commits intogophercloud:masterfrom
Conversation
|
Build failed.
|
Contributor
Author
|
fixing... |
767de24 to
d32ba5d
Compare
|
Build succeeded.
|
Contributor
|
Superseded by #2050 |
mandre
added a commit
to shiftstack/gophercloud
that referenced
this pull request
May 23, 2022
Use HTTP listener rather than TCP listener for the L7 policies tests.
Jobs would otherwise fail with:
Provider 'amphora' does not support a requested option: TCP protocol
listeners do not support L7 policies
Which is in-line with the documentation [1]:
Pools of type SCTP, TCP or UDP cannot be used in L7 policies at this
time.
Fixes gophercloud#2049.
[1] https://docs.openstack.org/api-ref/load-balancer/v2/index.html?expanded=create-an-l7-policy-detail#create-an-l7-policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #514
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/neutron-fwaas/blob/stable/ussuri/neutron_fwaas/db/firewall/v2/firewall_db_v2.py#L85-L103
https://github.com/openstack/neutron-fwaas/blob/stable/ussuri/neutron_fwaas/db/firewall/v2/firewall_db_v2.py#L307:L322
https://github.com/openstack/neutron-fwaas/blob/stable/ussuri/neutron_fwaas/services/firewall/fwaas_plugin_v2.py#L313-L369
this PR:
FWaaSv2 Update & Delete firewall-groups
next PRs:
Acceptance test for fwaasv2 firewall groups
kind regards,
Georg
Georg Schreiber georg.g.schreiber@daimler.com, Daimler TSS GmbH, legal info/Impressum