Build succeeded.

• gophercloud-unittest : SUCCESS in 3m 52s
• gophercloud-acceptance-test : SUCCESS in 1h 11m 48s
• gophercloud-acceptance-test-ironic : SUCCESS in 31m 15s

fixing...

Coverage increased (+0.02%) to 79.657% when pulling b380153 on Daimler:fwaasv2-firewall-groups-acc-tests into 9ee271d on gophercloud:master.

Build succeeded.

• gophercloud-unittest : SUCCESS in 3m 04s
• gophercloud-acceptance-test : SUCCESS in 1h 45m 37s
• gophercloud-acceptance-test-ironic : SUCCESS in 22m 23s

@codemanufaktur Unfortunately the testing environment is not configured for FWaaS v2. Are you able to provide the output of these unit tests with the OS_DEBUG=1 environment variable set? Please make sure to censor/sanitize any important information.

The output might be long, so perhaps a GitHub Gist is the best method of sharing.

Please let me know if you have any questions or problems.

@jtopjian sure, here is the output of acceptance/openstack/networking/v2/extensions/fwaas_v2/groups_test.go: gist

@codemanufaktur Thanks!

As far as I can tell, the whole series of PRs is good and we can look at just squashing and merging this one. Thank you for your work with all of the API calls.

The last thing I'd like to confirm is if paging is working correctly. Unfortunately I don't have a FWaaSv2 environment available and since the testing environment doesn't support FWaaSv2, would you mind testing this? I apologize for the extra work - this is something I usually do myself with PRs.

The easiest way to test this is if you create a few groups and then list them using a ListOpts.Limit of 1. Something like:

listOpts := groups.ListOpts{
  Limit: 1,
}

allPages, err := groups.List(client, listOpts).AllPages()

In the debug output, you should be able to see multiple GET requests. For example, if you create 3 groups, then there should be 3 GET requests, the first two having links for the next page.

@codemanufaktur Thanks!

As far as I can tell, the whole series of PRs is good and we can look at just squashing and merging this one. Thank you for your work with all of the API calls.

The last thing I'd like to confirm is if paging is working correctly. Unfortunately I don't have a FWaaSv2 environment available and since the testing environment doesn't support FWaaSv2, would you mind testing this? I apologize for the extra work - this is something I usually do myself with PRs.

The easiest way to test this is if you create a few groups and then list them using a ListOpts.Limit of 1. Something like:

listOpts := groups.ListOpts{
  Limit: 1,
}

allPages, err := groups.List(client, listOpts).AllPages()

In the debug output, you should be able to see multiple GET requests. For example, if you create 3 groups, then there should be 3 GET requests, the first two having links for the next page.

I have 1 default firewall group, created 4 additional firewall groups and listed them with Limit: 1. I see 5 GET requests in the debug-output. I think paging is working as expected.

@jtopjian paging looks ok imho. I squashed my 4 commits to one, hope the commit message looks OK :-)

Build succeeded.

• gophercloud-unittest : SUCCESS in 4m 17s
• gophercloud-acceptance-test : SUCCESS in 2h 34m 10s
• gophercloud-acceptance-test-ironic : SUCCESS in 50m 41s