Skip to content

Support health_status and health_status_reason attributes#1910

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
openstacker:magnum-health-status
Mar 28, 2020
Merged

Support health_status and health_status_reason attributes#1910
jtopjian merged 1 commit intogophercloud:masterfrom
openstacker:magnum-health-status

Conversation

@openstacker
Copy link
Copy Markdown
Contributor

For #1909

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://review.opendev.org/#/c/710384/

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 78.75% when pulling 211e2df on openstacker:magnum-health-status into ab68fb5 on gophercloud:master.

@openstacker
Copy link
Copy Markdown
Contributor Author

@jtopjian Could you please help review this one? Thanks.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 28, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 8337c28 into gophercloud:master Mar 28, 2020
openstacker added a commit to openstacker/gophercloud that referenced this pull request May 18, 2020
This is a regression issue introduced by[1], which may impact the
cluster Get. The health_status_reason attribute should be a dict
instead of string.

[1] gophercloud#1910
openstacker added a commit to openstacker/gophercloud that referenced this pull request May 18, 2020
This is a regression issue introduced by[1], which may impact the
cluster Get. The health_status_reason attribute should be a dict
instead of string.

[1] gophercloud#1910
jtopjian pushed a commit that referenced this pull request May 18, 2020
This is a regression issue introduced by[1], which may impact the
cluster Get. The health_status_reason attribute should be a dict
instead of string.

[1] #1910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants