ContainerInfra v1: Fix cluster Get#1968
Merged
jtopjian merged 1 commit intogophercloud:masterfrom May 18, 2020
Merged
Conversation
This is a regression issue introduced by[1], which may impact the cluster Get. The health_status_reason attribute should be a dict instead of string. [1] gophercloud#1910
0e847c5 to
aea91bb
Compare
|
Build succeeded.
|
Contributor
Author
|
@jtopjian I'm sorry this is a regression issue. Please review it as it's blocked the very basic cluster Get function. BTW, when the version 0.12 will be released? Thanks. |
Contributor
Probably not until next month. |
jtopjian
approved these changes
May 18, 2020
| FixedNetwork string `json:"fixed_network"` | ||
| FixedSubnet string `json:"fixed_subnet"` | ||
| HealthStatus string `json:"health_status"` | ||
| HealthStatusReason map[string]interface{} `json:"health_status_reason"` |
Contributor
There was a problem hiding this comment.
Contributor
|
@openstacker We've had a few other small bug fixes come in. If you can confirm this works, I can release version 0.11.1 for you - if that would help? |
Contributor
Author
Thank you very much. I think I can just use the latest commit in CPO. That's OK. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a regression issue introduced by[1], which may impact the
cluster Get. The health_status_reason attribute should be a dict
instead of a string.
[1] #1910
For #1909