Baremetal Introspection: Add hostname to introspection data#1617
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jun 12, 2019
Merged
Baremetal Introspection: Add hostname to introspection data#1617jtopjian merged 1 commit intogophercloud:masterfrom
jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
A patch is being made to the Ironic Python Agent to return the hostname that the introspected machine thinks it has. This enables Gophercloud to pass that along. Requires: https://review.opendev.org/#/c/663991/
|
Build succeeded.
|
jtopjian
reviewed
Jun 12, 2019
| MACs []string `json:"macs"` | ||
| MemoryMB int `json:"memory_mb"` | ||
| RootDisk RootDiskType `json:"root_disk"` | ||
| Hostname string `json:"hostname,omitempty"` |
Contributor
There was a problem hiding this comment.
nit: omitempty is only needed for structs that will send a JSON body in an API request. Since this is a result, it's not needed. I'll fix this post-merge.
zaneb
added a commit
to zaneb/baremetal-operator
that referenced
this pull request
Jun 13, 2019
This change pulls in: - Hostname support in Baremetal introspection gophercloud/gophercloud#1617 - extra_hardware support for Baremetal introspection gophercloud/gophercloud#1611 Signed-off-by: Zane Bitter <zbitter@redhat.com>
zaneb
added a commit
to zaneb/baremetal-operator
that referenced
this pull request
Jun 13, 2019
This change pulls in: - Hostname support in Baremetal introspection gophercloud/gophercloud#1617 - extra_hardware support for Baremetal introspection gophercloud/gophercloud#1611 Signed-off-by: Zane Bitter <zbitter@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A patch is being made to the Ironic Python Agent to return the hostname
that the introspected machine thinks it has. This enables Gophercloud
to pass that along.
For #1616
https://review.opendev.org/#/c/663991/