Skip to content

Baremetal introspection: Read extra_hardware data#1611

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
zaneb:extra_hardware
Jun 13, 2019
Merged

Baremetal introspection: Read extra_hardware data#1611
jtopjian merged 1 commit intogophercloud:masterfrom
zaneb:extra_hardware

Conversation

@zaneb
Copy link
Copy Markdown
Contributor

@zaneb zaneb commented Jun 10, 2019

If the extra_hardware processing hook is enabled in ironic-inspector,
then additional data is provided as a top-level object named "extra",
with a number of sections, each of which is also an object containing
objects with various key/value data.

For #1485

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://opendev.org/openstack/ironic-inspector/src/branch/master/ironic_inspector/plugins/extra_hardware.py

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 10, 2019

Coverage Status

Coverage remained the same at 76.79% when pulling 73b2b9e on zaneb:extra_hardware into a22a3d3 on gophercloud:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 10, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 76.819% when pulling f51ce6f on zaneb:extra_hardware into f5fa3f8 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 10, 2019

Build succeeded.

dhellmann
dhellmann approved these changes Jun 10, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every OpenStack API designer should be required to describe the client-side of their API in a statically typed language before proceeding with implementation. :-)

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Jun 11, 2019

This looks good to me and I trust that it works.

If it's not too much trouble, would you be able to add a unit test or amend an existing one? I think it would also serve as a form of documentation for those who dug into the tests. The only reason I raise this is because mentally building a map[string]map[string]interface{} in one's head might be a challenge.

Every OpenStack API designer should be required to describe the client-side of their API in a statically typed language before proceeding with implementation.

🙂

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 12, 2019

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@zaneb
Copy link
Copy Markdown
Contributor Author

zaneb commented Jun 12, 2019

mentally building a map[string]map[string]interface{} in one's head might be a challenge

I assumed you gophers would be used to that ;)

@zaneb
Baremetal introspection: Read extra_hardware data
f51ce6f 
If the extra_hardware processing hook is enabled in ironic-inspector,
then additional data is provided as a top-level object named "extra",
with a number of sections, each of which is also an object containing
objects with various key/value data.

Signed-off-by: Zane Bitter <zbitter@redhat.com>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 12, 2019

Build failed.

@zaneb
Copy link
Copy Markdown
Contributor Author

zaneb commented Jun 12, 2019

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 13, 2019

Build succeeded.

jtopjian
jtopjian approved these changes Jun 13, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit b43c168 into gophercloud:master Jun 13, 2019
zaneb added a commit to zaneb/baremetal-operator that referenced this pull request Jun 13, 2019
@zaneb
Update to latest gophrecloud revision
f38238f 
This change pulls in:

 - Hostname support in Baremetal introspection
   gophercloud/gophercloud#1617
 - extra_hardware support for Baremetal introspection
   gophercloud/gophercloud#1611

Signed-off-by: Zane Bitter <zbitter@redhat.com>
zaneb added a commit to zaneb/baremetal-operator that referenced this pull request Jun 13, 2019
@zaneb
Update to latest gophercloud revision
7c77bcf 
This change pulls in:

 - Hostname support in Baremetal introspection
   gophercloud/gophercloud#1617
 - extra_hardware support for Baremetal introspection
   gophercloud/gophercloud#1611

Signed-off-by: Zane Bitter <zbitter@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtopjian jtopjian jtopjian approved these changes

+1 more reviewer

@dhellmann dhellmann dhellmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zaneb @coveralls @jtopjian @dhellmann