-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat!: Add support for setOnInfoWindowLongClickListener() for Markers #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: Note that this could be considered a breaking change because `ClusterRenderer` is a `public interface` and may be used outside of the library if apps implemented their own renderer. Also, if apps were doing `map.setOnInfoWindowLongClickListener()` on their own this implementation will break that behavior and force them to use the collection info window long click listener, similar to how info window click listeners are currently handled (see the [Migration Guide](https://github.com/googlemaps/android-maps-utils#adding-a-custom-info-window). Closes #750
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
- Coverage 39.48% 39.20% -0.29%
==========================================
Files 71 71
Lines 4047 4076 +29
Branches 606 609 +3
==========================================
Hits 1598 1598
- Misses 2346 2375 +29
Partials 103 103
Continue to review full report at Codecov.
|
# [2.0.0](v1.3.3...v2.0.0) (2020-06-19) * feat!: Add support for setOnInfoWindowLongClickListener() for Markers (#752) ([8a3fc01](8a3fc01)), closes [#752](#752) [#750](#750) ### BREAKING CHANGES * Note that this could be considered a breaking change because `ClusterRenderer` is a `public interface` and may be used outside of the library if apps implemented their own renderer. Also, if apps were doing `map.setOnInfoWindowLongClickListener()` on their own this implementation will break that behavior and force them to use the collection info window long click listener, similar to how info window click listeners are currently handled (see the [Migration Guide](https://github.com/googlemaps/android-maps-utils#adding-a-custom-info-window).
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Follow up to implementing the feature in #752.
Follow up to implementing the feature in #752.
Follow up to implementing the feature in #752.
Follow up to implementing the feature in #752. Co-authored-by: Enrique López Mañas <eenriquelopez@gmail.com>
As mentioned in #750, we currently support clicking on info windows for markers in the library, but not long clicking. This PR implements long clicking as well.
BREAKING CHANGE: Note that this could be considered a breaking change because
ClusterRendereris apublic interfaceand may be used outside of the library if apps implemented their own renderer. Also, if apps were doingmap.setOnInfoWindowLongClickListener()on their own this implementation will break that behavior and force them to use the collection info window long click listener, similar to how info window click listeners are currently handled (see the Migration Guide).I've tested this in the demo app with:
...and it works, although I can't add the above code in a PR until this is released and we bump the demo app version.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
BREAKING CHANGEfooter so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/Fixes #750 🦕