docs: Add long click listener to cluster demo #754
Conversation
Codecov Report
@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 39.20% 39.20%
=======================================
Files 71 71
Lines 4076 4076
Branches 609 609
=======================================
Hits 1598 1598
Misses 2375 2375
Partials 103 103 Continue to review full report at Codecov.
|
| Toast.makeText(ClusteringDemoActivity.this, | ||
| "Info window clicked.", | ||
| Toast.LENGTH_SHORT).show()); | ||
| mClusterManager.getMarkerCollection().setOnInfoWindowLongClickListener(marker -> |
There was a problem hiding this comment.
Should this be preferred over setting listeners through mClusterManager.setOnClusterItemInfoWindowLongClickListener/mClusterManager.setOnClusterInfoWindowLongClickListener?
There was a problem hiding this comment.
Hmm, good question. To be honest I was following the existing pattern for setOnInfoWindowClickListener() - let me take a closer look.
There was a problem hiding this comment.
@barbeau , may I apply this change? I think setting the listener directly on the Cluster makes more sense - I can update this file to reflect that.
There was a problem hiding this comment.
To be honest it's been a while since I've looked at this, and I recall it not being straightforward but I don't recall the details. I'll trust your judgment on what you think is the best path forward. 😁
There was a problem hiding this comment.
I have added the listener directly to the Cluster. @wangela , if you have some time a review here would be appreciated.
e4d4592 to
5c2d193
Compare
Follow up to implementing the feature in #752.
3a72c95 to
aa98df0
Compare
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Follow up to implementing the feature in #752.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
BREAKING CHANGEfooter so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/