This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Conversation
tswast
suggested changes
Apr 11, 2024
Contributor
tswast
left a comment
There was a problem hiding this comment.
The samples need to be one directory deeper. Could you please make a samples/bigquery folder for the %%bigquery code samples?
Contributor
|
Looking at #6, the recommended folder name is |
tswast
reviewed
Apr 11, 2024
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
ashleyxuu
commented
Apr 12, 2024
9db0a67 to
f2e4f34
Compare
tswast
reviewed
Apr 12, 2024
bigquery_magics/bigquery.py
Outdated
| from google.api_core.exceptions import NotFound | ||
| from google.cloud import bigquery | ||
| from google.cloud.bigquery import exceptions | ||
| from google.cloud.bigquery import _versions_helpers, exceptions |
Contributor
There was a problem hiding this comment.
Please don't.
That's a private module. Let's use the one we copied to this repo, instead.
tswast
reviewed
Apr 12, 2024
samples/snippets/requirements.txt
Outdated
Comment on lines
+1
to
+9
| db-dtypes==1.2.0 | ||
| google.cloud.bigquery==3.19.0 | ||
| google-cloud-bigquery-storage==2.24.0 | ||
| ipython===7.31.1; python_version == '3.7' | ||
| ipython===8.0.1; python_version == '3.8' | ||
| ipython===8.18.1; python_version >= '3.9' | ||
| pandas==1.3.5; python_version == '3.7' | ||
| pandas==2.0.0; python_version == '3.8' | ||
| pandas==2.2.1; python_version >= '3.9' |
Contributor
There was a problem hiding this comment.
Ideally this will just be bigquery_magics with no extra dependencies. See this comment: https://github.com/googleapis/python-bigquery/blob/bf8861c3473a1af978db7a06463ddc0bad86f326/samples/snippets/requirements.txt#L1
tswast
reviewed
Apr 12, 2024
d3a899e to
4d12f97
Compare
* chore: copy magics unit tests from google-cloud-bigquery * update tests to use bigquery_magics module * remove auth from unit tests * fix coverage
* chore: copy magics unit tests from google-cloud-bigquery * update tests to use bigquery_magics module * remove auth from unit tests * fix coverage
d012645 to
d4fd1ae
Compare
c6aca5f to
1105998
Compare
tswast
reviewed
Apr 15, 2024
0ae053e to
1d21466
Compare
87ab992 to
2be7369
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.