This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Conversation
tswast
commented
Apr 9, 2024
Contributor
Author
|
Might be a good idea to get |
Contributor
Author
|
Marking as |
chalmerlowe
reviewed
Apr 11, 2024
|
|
||
| - The feature must work fully on the following CPython versions: | ||
| 3.7, 3.8, 3.9, 3.10, 3.11 and 3.12 on both UNIX and Windows. | ||
| 3.7, 3.8, 3.11 and 3.12 on both UNIX and Windows. |
There was a problem hiding this comment.
Curious: why the de-emphasis on versions 3.9 and 3.10?
Contributor
Author
There was a problem hiding this comment.
I think this is taking the unit test versions from owlbot. We do want it to work on these, but I wonder if it's worth testing against so many versions?
I don't see |
Contributor
Author
Oops. Merged that in #8 The owlbot lock files actually activates it. |
ashleyxuu
pushed a commit
that referenced
this pull request
Apr 12, 2024
* chore: synchronize with Python templates * add owlbot configuration * remove unknown paths from linter * use templated noxfile * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * multiple teams: see: googleapis/synthtool#946 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: grant api-bigquery and api-bigquery-dataframe teams write access to repo * add python 3.7 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: copy magics unit tests from google-cloud-bigquery * include google-cloud-testutils in unittests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * use bqstorage extras * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * use extras by python for everything * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update tests to use bigquery_magics module * remove auth from unit tests * fix coverage --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review #8 first! This PR depends on changes made in that PR.
Only 1 file here is hand-written:
owlbot.py