Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore: copy %%bigquery magics tests from google-cloud-bigquery#8

Merged
tswast merged 4 commits intomainfrom
tswast-unit-tests
Apr 11, 2024
Merged

chore: copy %%bigquery magics tests from google-cloud-bigquery#8
tswast merged 4 commits intomainfrom
tswast-unit-tests

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Apr 10, 2024

Tests based on this search: https://github.com/search?q=repo%3Agoogleapis%2Fpython-bigquery+path%3A%2F%5Etests%5C%2F%2F+magics&type=code

See: cl/623605299 for enabling Kokoro on this repo.

  • The first commit (fa3ce9f) copies the tests as-is from google-cloud-bigquery and updates the setup.py file to the correct dependencies and package name.
  • The second commit (b23de2a) updates the tests to use the bigquery-magics package.
  • The third commit (8ef9b2c) mocks out auth in more tests so they are true unit tests.
  • The fourth commit (ae835f6) addresses the remaining unit test coverage issues.

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-magics API. label Apr 10, 2024
@tswast tswast force-pushed the tswast-unit-tests branch from b47b189 to 342c8f0 Compare April 10, 2024 16:39
@tswast tswast force-pushed the tswast-unit-tests branch from 342c8f0 to fa3ce9f Compare April 10, 2024 16:41
Copy link
Copy Markdown
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tswast tswast merged commit 30d05bc into main Apr 11, 2024
@tswast tswast deleted the tswast-unit-tests branch April 11, 2024 19:29
ashleyxuu pushed a commit that referenced this pull request Apr 12, 2024
* chore: copy magics unit tests from google-cloud-bigquery

* update tests to use bigquery_magics module

* remove auth from unit tests

* fix coverage
ashleyxuu pushed a commit that referenced this pull request Apr 12, 2024
* chore: copy magics unit tests from google-cloud-bigquery

* update tests to use bigquery_magics module

* remove auth from unit tests

* fix coverage
ashleyxuu pushed a commit that referenced this pull request Apr 12, 2024
* chore: copy magics unit tests from google-cloud-bigquery

* update tests to use bigquery_magics module

* remove auth from unit tests

* fix coverage
ashleyxuu pushed a commit that referenced this pull request Apr 12, 2024
* chore: copy magics unit tests from google-cloud-bigquery

* update tests to use bigquery_magics module

* remove auth from unit tests

* fix coverage
tswast added a commit that referenced this pull request Apr 15, 2024
* chore: add the sample test for magics

* re-arrange directory and make nox -s pass

* chore: add the sample test for magics

* chore: copy `%%bigquery` magics tests from google-cloud-bigquery (#8)

* chore: copy magics unit tests from google-cloud-bigquery

* update tests to use bigquery_magics module

* remove auth from unit tests

* fix coverage

* re-arrange directory and make nox -s pass

* delete files

* test the version

* chore: add the sample test for magics

* re-arrange directory and make nox -s pass

* chore: add the sample test for magics

* chore: copy `%%bigquery` magics tests from google-cloud-bigquery (#8)

* chore: copy magics unit tests from google-cloud-bigquery

* update tests to use bigquery_magics module

* remove auth from unit tests

* fix coverage

* re-arrange directory and make nox -s pass

* delete files

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* delete files

* address comments

* fix the merging conflicts

* set local version of variables

* address comments

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-magics API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants