Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

chore: fix type errors in build#2577

Merged
ddelgrosso1 merged 3 commits intomainfrom
fix-build
Feb 11, 2025
Merged

chore: fix type errors in build#2577
ddelgrosso1 merged 3 commits intomainfrom
fix-build

Conversation

@ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented Feb 4, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested a review from a team February 4, 2025 15:34
@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner February 4, 2025 15:34
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Feb 4, 2025
@ddelgrosso1
Copy link
Contributor Author

ddelgrosso1 commented Feb 4, 2025

Noticed the nightly builds have been failing due to some recent type updates in @types/node

@ddelgrosso1 ddelgrosso1 merged commit 86f77ce into main Feb 11, 2025
19 checks passed
@ddelgrosso1 ddelgrosso1 deleted the fix-build branch February 11, 2025 15:19
ddelgrosso1 added a commit that referenced this pull request Mar 4, 2025
@thiyaguk09 @ddelgrosso1
@release-please @gcf-owl-bot @danielduhh @jjaareet
chore!: gaxios rebase node 18 (#2569)
7ec0bf7 
* chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient

* remove service class and associated tests

* modify service-object and associated sub classes to use storage transport

* begin refactoring classes to use storage-transport

* finish initial refactor of classes

* fix compilation errors

* add header to storage-transport.ts

* fix service-object unit tests

* fix common-util tests

* fix acl tests

* fix channel tests

* fix headers tests

* fix iam tests

* fix index tests

* fix notification tests

* remove teeny-request and retry request from deps

* fix arguments and urls of create bucket

* fix multipart upload urls

* fix stream handling in createReadStream

* feat: add ability to configure and utilize soft-delete and restore buckets (#2566)

* Adds support for the restore token feature

* description fix

* lint fix

* fetch softDeleted bucket list & details

fetch softDeleted bucket list & details

* initial commit for bucket restore

initial commit for bucket restore

* fix missing license headers

fix missing license headers

* lint fix

* test case bug fix

* added restore bucket unit test cases

* added restore bucket system test

added restore bucket system test

* lint fix

* format

format

* system test fix

* fix

* chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient

* remove service class and associated tests

* modify service-object and associated sub classes to use storage transport

* begin refactoring classes to use storage-transport

* finish initial refactor of classes

* fix compilation errors

* add header to storage-transport.ts

* fix service-object unit tests

* fix common-util tests

* fix acl tests

* fix channel tests

* fix headers tests

* fix iam tests

* fix index tests

* fix notification tests

* remove teeny-request and retry request from deps

* fix arguments and urls of create bucket

* fix multipart upload urls

* fix stream handling in createReadStream

* fix compilation errors

* fix lint issues

fix lint issues

* test case fix

* lint fix

lint fix

* lint and test case fix

lint and test case fixes

* chore(main): release 7.15.0 (#2568)

* chore(main): release 7.15.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: replace reference docs link with RAD (#2571)

* fix bucket tests

* fix(getFiles): add nextPageToken to fields for autoPaginate (#2570)

* fix storage-transport test

* fix file tests

* conformance test fix

* fix error

* fix buffer error

* comment failed conformance test

* comments addressed

* refactoring the storage-transport classes to utilize Promises

* chore: fix type errors in build (#2577)

* chore: fix type errors in build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs links

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 7.15.1 (#2573)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix license issue

---------

Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel B <danielduhh@gmail.com>
Co-authored-by: Jarrett <2613089+jjaareet@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
ddelgrosso1 added a commit that referenced this pull request Mar 13, 2025
@thiyaguk09 @release-please
@gcf-owl-bot @danielduhh @jjaareet @ddelgrosso1 @terite
fix: Improve projectId handling in authentication (#2584)
6d94e45 
* feat: add ability to configure and utilize soft-delete and restore buckets (#2566)

* Adds support for the restore token feature

* description fix

* lint fix

* fetch softDeleted bucket list & details

fetch softDeleted bucket list & details

* initial commit for bucket restore

initial commit for bucket restore

* fix missing license headers

fix missing license headers

* lint fix

* test case bug fix

* added restore bucket unit test cases

* added restore bucket system test

added restore bucket system test

* lint fix

* format

format

* system test fix

* chore(main): release 7.15.0 (#2568)

* chore(main): release 7.15.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: replace reference docs link with RAD (#2571)

* fix(getFiles): add nextPageToken to fields for autoPaginate (#2570)

* chore: fix type errors in build (#2577)

* chore: fix type errors in build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs links

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 7.15.1 (#2573)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix: export SaveData type from index.ts (#2580)

* chore(main): release 7.15.2 (#2581)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: set gcs-sdk-team as CODEOWNERS  (#2582)

* Set CODEOWNERS as gcs-sdk-team

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update repo metadata with new team

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix broken types causing compilation failures

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>

* fix: Improve projectId handling in authentication

Improve projectId handling in authentication and resolve issue in patch
request

* bug fix

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel B <danielduhh@gmail.com>
Co-authored-by: Jarrett <2613089+jjaareet@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
Co-authored-by: David Stensland <me@terite.com>
Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
thiyaguk09 added a commit to thiyaguk09/nodejs-storage-fork that referenced this pull request May 2, 2025
@thiyaguk09 @ddelgrosso1
@release-please @gcf-owl-bot @danielduhh @jjaareet
chore!: gaxios rebase node 18 (googleapis#2569)
13fbe07 
* chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient

* remove service class and associated tests

* modify service-object and associated sub classes to use storage transport

* begin refactoring classes to use storage-transport

* finish initial refactor of classes

* fix compilation errors

* add header to storage-transport.ts

* fix service-object unit tests

* fix common-util tests

* fix acl tests

* fix channel tests

* fix headers tests

* fix iam tests

* fix index tests

* fix notification tests

* remove teeny-request and retry request from deps

* fix arguments and urls of create bucket

* fix multipart upload urls

* fix stream handling in createReadStream

* feat: add ability to configure and utilize soft-delete and restore buckets (googleapis#2566)

* Adds support for the restore token feature

* description fix

* lint fix

* fetch softDeleted bucket list & details

fetch softDeleted bucket list & details

* initial commit for bucket restore

initial commit for bucket restore

* fix missing license headers

fix missing license headers

* lint fix

* test case bug fix

* added restore bucket unit test cases

* added restore bucket system test

added restore bucket system test

* lint fix

* format

format

* system test fix

* fix

* chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient

* remove service class and associated tests

* modify service-object and associated sub classes to use storage transport

* begin refactoring classes to use storage-transport

* finish initial refactor of classes

* fix compilation errors

* add header to storage-transport.ts

* fix service-object unit tests

* fix common-util tests

* fix acl tests

* fix channel tests

* fix headers tests

* fix iam tests

* fix index tests

* fix notification tests

* remove teeny-request and retry request from deps

* fix arguments and urls of create bucket

* fix multipart upload urls

* fix stream handling in createReadStream

* fix compilation errors

* fix lint issues

fix lint issues

* test case fix

* lint fix

lint fix

* lint and test case fix

lint and test case fixes

* chore(main): release 7.15.0 (googleapis#2568)

* chore(main): release 7.15.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: replace reference docs link with RAD (googleapis#2571)

* fix bucket tests

* fix(getFiles): add nextPageToken to fields for autoPaginate (googleapis#2570)

* fix storage-transport test

* fix file tests

* conformance test fix

* fix error

* fix buffer error

* comment failed conformance test

* comments addressed

* refactoring the storage-transport classes to utilize Promises

* chore: fix type errors in build (googleapis#2577)

* chore: fix type errors in build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs links

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 7.15.1 (googleapis#2573)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix license issue

---------

Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel B <danielduhh@gmail.com>
Co-authored-by: Jarrett <2613089+jjaareet@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
thiyaguk09 added a commit to thiyaguk09/nodejs-storage-fork that referenced this pull request May 2, 2025
@thiyaguk09 @release-please
@gcf-owl-bot @danielduhh @jjaareet @ddelgrosso1 @terite
fix: Improve projectId handling in authentication (googleapis#2584)
afab674 
* feat: add ability to configure and utilize soft-delete and restore buckets (googleapis#2566)

* Adds support for the restore token feature

* description fix

* lint fix

* fetch softDeleted bucket list & details

fetch softDeleted bucket list & details

* initial commit for bucket restore

initial commit for bucket restore

* fix missing license headers

fix missing license headers

* lint fix

* test case bug fix

* added restore bucket unit test cases

* added restore bucket system test

added restore bucket system test

* lint fix

* format

format

* system test fix

* chore(main): release 7.15.0 (googleapis#2568)

* chore(main): release 7.15.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: replace reference docs link with RAD (googleapis#2571)

* fix(getFiles): add nextPageToken to fields for autoPaginate (googleapis#2570)

* chore: fix type errors in build (googleapis#2577)

* chore: fix type errors in build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs links

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 7.15.1 (googleapis#2573)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix: export SaveData type from index.ts (googleapis#2580)

* chore(main): release 7.15.2 (googleapis#2581)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: set gcs-sdk-team as CODEOWNERS  (googleapis#2582)

* Set CODEOWNERS as gcs-sdk-team

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update repo metadata with new team

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix broken types causing compilation failures

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>

* fix: Improve projectId handling in authentication

Improve projectId handling in authentication and resolve issue in patch
request

* bug fix

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel B <danielduhh@gmail.com>
Co-authored-by: Jarrett <2613089+jjaareet@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
Co-authored-by: David Stensland <me@terite.com>
Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
thiyaguk09 added a commit to thiyaguk09/nodejs-storage-fork that referenced this pull request May 2, 2025
@thiyaguk09 @ddelgrosso1
@release-please @gcf-owl-bot @danielduhh @jjaareet
chore!: gaxios rebase node 18 (googleapis#2569)
fb31536 
* chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient

* remove service class and associated tests

* modify service-object and associated sub classes to use storage transport

* begin refactoring classes to use storage-transport

* finish initial refactor of classes

* fix compilation errors

* add header to storage-transport.ts

* fix service-object unit tests

* fix common-util tests

* fix acl tests

* fix channel tests

* fix headers tests

* fix iam tests

* fix index tests

* fix notification tests

* remove teeny-request and retry request from deps

* fix arguments and urls of create bucket

* fix multipart upload urls

* fix stream handling in createReadStream

* feat: add ability to configure and utilize soft-delete and restore buckets (googleapis#2566)

* Adds support for the restore token feature

* description fix

* lint fix

* fetch softDeleted bucket list & details

fetch softDeleted bucket list & details

* initial commit for bucket restore

initial commit for bucket restore

* fix missing license headers

fix missing license headers

* lint fix

* test case bug fix

* added restore bucket unit test cases

* added restore bucket system test

added restore bucket system test

* lint fix

* format

format

* system test fix

* fix

* chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient

* remove service class and associated tests

* modify service-object and associated sub classes to use storage transport

* begin refactoring classes to use storage-transport

* finish initial refactor of classes

* fix compilation errors

* add header to storage-transport.ts

* fix service-object unit tests

* fix common-util tests

* fix acl tests

* fix channel tests

* fix headers tests

* fix iam tests

* fix index tests

* fix notification tests

* remove teeny-request and retry request from deps

* fix arguments and urls of create bucket

* fix multipart upload urls

* fix stream handling in createReadStream

* fix compilation errors

* fix lint issues

fix lint issues

* test case fix

* lint fix

lint fix

* lint and test case fix

lint and test case fixes

* chore(main): release 7.15.0 (googleapis#2568)

* chore(main): release 7.15.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: replace reference docs link with RAD (googleapis#2571)

* fix bucket tests

* fix(getFiles): add nextPageToken to fields for autoPaginate (googleapis#2570)

* fix storage-transport test

* fix file tests

* conformance test fix

* fix error

* fix buffer error

* comment failed conformance test

* comments addressed

* refactoring the storage-transport classes to utilize Promises

* chore: fix type errors in build (googleapis#2577)

* chore: fix type errors in build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs links

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 7.15.1 (googleapis#2573)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix license issue

---------

Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel B <danielduhh@gmail.com>
Co-authored-by: Jarrett <2613089+jjaareet@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bajajneha27 bajajneha27 bajajneha27 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddelgrosso1 @bajajneha27