chore!: gaxios rebase node 18 by thiyaguk09 · Pull Request #2569 · googleapis/nodejs-storage

thiyaguk09 · 2025-01-08T05:46:59Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…port

…ckets (googleapis#2566) * Adds support for the restore token feature * description fix * lint fix * fetch softDeleted bucket list & details fetch softDeleted bucket list & details * initial commit for bucket restore initial commit for bucket restore * fix missing license headers fix missing license headers * lint fix * test case bug fix * added restore bucket unit test cases * added restore bucket system test added restore bucket system test * lint fix * format format * system test fix

…port

conformance-test/conformanceCommon.ts

src/file.ts

ddelgrosso1 · 2025-02-03T15:29:42Z

src/iam.ts

    }

-    this.request_(
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises


Why is this disable necessary? Looks like errors are being handled in the callback. I'd rather we not add these disables if possible.

Your concern about the disable is valid. The linter indicates that because this.storageTransport.makeRequest likely returns a Promise, we must handle potential rejections. Even though we have a callback, the Promise itself might reject, and we need to account for that. Therefore, we are suppressing the warning.

Interesting... this must be a more recent linter change as it didn't complain when I originally wrote storage-transport.ts. Maybe it is worth revisiting the signature / implementation for storage-transport.request. Having to add a disable every time we use a callback to that function is not ideal and has a bit of a code smell to it.

I've addressed the issue with the storage-transport.request function and the related linter warnings. Could you please review these changes?

ddelgrosso1 · 2025-02-03T15:29:55Z

src/iam.ts

    }

-    this.request_(
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises


Same comment about this disable.

* chore: fix type errors in build * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix docs links --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ddelgrosso1 · 2025-02-13T14:30:53Z

src/acl.ts


-        if (resp.items) {
-          results = resp.items.map(this.makeAclObject_);
+        if ((data as any).items) {


We should be able to pass a type to makeRequest and avoid an any cast here. We can then remove the linter disable for this file.

src/crc32c.ts

ddelgrosso1 · 2025-02-13T14:32:48Z

src/iam.ts

+        queryParameters: req as unknown as StorageQueryParameters,
+      })
+      .then(({data, resp}) => {
+        const availablePermissions = Array.isArray((data as any).permissions)


If possible let's try and avoid these any casts and disabling the any linter rules.

generated-files-bot · 2025-02-21T11:41:29Z

Warning: This pull request is touching the following templated files:

README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml
samples/README.md - samples/README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

snippet-bot · 2025-02-21T11:41:29Z

Here is the summary of changes.

You are about to add 3 region tags.

samples/getSoftDeletedBucket.js:18, tag storage_get_soft_deleted_bucket
samples/listSoftDeletedBucket.js:18, tag storage_list_soft_deleted_buckets
samples/restoreSoftDeletedBucket.js:18, tag storage_restore_soft_deleted_bucket

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

danielduhh · 2025-03-04T06:13:47Z

Is this good to merge @ddelgrosso1 ?

ddelgrosso1 · 2025-03-04T12:58:27Z

@danielduhh yes, this is pointed at the node 18 staging branch. Safe to merge while the conformance tests are fixed.

* chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient * remove service class and associated tests * modify service-object and associated sub classes to use storage transport * begin refactoring classes to use storage-transport * finish initial refactor of classes * fix compilation errors * add header to storage-transport.ts * fix service-object unit tests * fix common-util tests * fix acl tests * fix channel tests * fix headers tests * fix iam tests * fix index tests * fix notification tests * remove teeny-request and retry request from deps * fix arguments and urls of create bucket * fix multipart upload urls * fix stream handling in createReadStream * feat: add ability to configure and utilize soft-delete and restore buckets (googleapis#2566) * Adds support for the restore token feature * description fix * lint fix * fetch softDeleted bucket list & details fetch softDeleted bucket list & details * initial commit for bucket restore initial commit for bucket restore * fix missing license headers fix missing license headers * lint fix * test case bug fix * added restore bucket unit test cases * added restore bucket system test added restore bucket system test * lint fix * format format * system test fix * fix * chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient * remove service class and associated tests * modify service-object and associated sub classes to use storage transport * begin refactoring classes to use storage-transport * finish initial refactor of classes * fix compilation errors * add header to storage-transport.ts * fix service-object unit tests * fix common-util tests * fix acl tests * fix channel tests * fix headers tests * fix iam tests * fix index tests * fix notification tests * remove teeny-request and retry request from deps * fix arguments and urls of create bucket * fix multipart upload urls * fix stream handling in createReadStream * fix compilation errors * fix lint issues fix lint issues * test case fix * lint fix lint fix * lint and test case fix lint and test case fixes * chore(main): release 7.15.0 (googleapis#2568) * chore(main): release 7.15.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * docs: replace reference docs link with RAD (googleapis#2571) * fix bucket tests * fix(getFiles): add nextPageToken to fields for autoPaginate (googleapis#2570) * fix storage-transport test * fix file tests * conformance test fix * fix error * fix buffer error * comment failed conformance test * comments addressed * refactoring the storage-transport classes to utilize Promises * chore: fix type errors in build (googleapis#2577) * chore: fix type errors in build * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix docs links --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 7.15.1 (googleapis#2573) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * fix license issue --------- Co-authored-by: Denis DelGrosso <ddelgrosso@google.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Daniel B <danielduhh@gmail.com> Co-authored-by: Jarrett <2613089+jjaareet@users.noreply.github.com> Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>

ddelgrosso1 and others added 30 commits July 15, 2024 19:16

chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient

3b1f7ac

remove service class and associated tests

612327f

modify service-object and associated sub classes to use storage trans…

2f60470

…port

begin refactoring classes to use storage-transport

b6aa18e

finish initial refactor of classes

1c0eabd

fix compilation errors

d69d43a

add header to storage-transport.ts

1cf0116

fix service-object unit tests

59c243d

fix common-util tests

e33d480

fix acl tests

6ed3cb3

fix channel tests

c10deff

fix headers tests

6a289ea

fix iam tests

e155b1b

fix index tests

0cdab1f

fix notification tests

ccb10d9

remove teeny-request and retry request from deps

7e0a12c

fix arguments and urls of create bucket

75deeb9

fix multipart upload urls

eeffcf7

fix stream handling in createReadStream

f283280

fix

66e78e0

chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient

932d421

remove service class and associated tests

7ae325d

modify service-object and associated sub classes to use storage trans…

7ce8cae

…port

begin refactoring classes to use storage-transport

48f51a6

finish initial refactor of classes

270841c

fix compilation errors

5f7f0ef

add header to storage-transport.ts

1a40954

fix service-object unit tests

d0aca3f

fix common-util tests

f6d523e

thiyaguk09 added 2 commits February 3, 2025 11:45

fix buffer error

6320862

comment failed conformance test

137dda4

thiyaguk09 marked this pull request as ready for review February 3, 2025 11:59

thiyaguk09 requested a review from a team February 3, 2025 11:59

thiyaguk09 requested a review from a team as a code owner February 3, 2025 11:59