chore: do not run CI on grpc-js #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
approved these changes
May 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 13 13
Lines 841 841
Branches 175 175
=======================================
Hits 825 825
Misses 1 1
Partials 15 15Continue to review full report at Codecov.
|
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
* Reads and filters WIP, working Reads tests and current format for Reads snippets * working tests for solo filters * Composing filters * add bulk region tags * Change testing instance * Linted * feat: implement instance and table level IAM policy (googleapis#584) * feat: add table level IAM policy controls * lint: lint * feat: add instance level IAM policy * docs: update description * docs: add document snippets * lint: lint * Linted Fixed headers Removed unnceccessary asyncs Arrow functions where possible * Arrow functions * destructure Bigtable require * Using snapshots for testing * Change functions to use a switch * Fix timezone issue for tests * Lint snapshot files * Clean up loops, add update snapshot method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very soon we'll move to
@grpc/grpc-jsand will start using it by default, so there is no need to have a separate CI task.