Skip to content

Conversation

@bcoe
Copy link

@bcoe bcoe commented May 2, 2019

This drops support for all Node.js versions < 8.10.0, please upgrade

BREAKING CHANGE: library now requires Node >= 8.10.0

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2019
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #584 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files          13       13           
  Lines         831      831           
  Branches      174      174           
=======================================
  Hits          815      815           
  Misses          1        1           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2004351...6a800b4. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 2116474 into master May 2, 2019
@JustinBeckwith JustinBeckwith deleted the update-engine-field-2-the-updates-revenge branch May 2, 2019 18:31
This was referenced Apr 29, 2020
@feywind feywind mentioned this pull request May 20, 2020
@release-please release-please bot mentioned this pull request May 20, 2020
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
* feat: add table level IAM policy controls

* lint: lint

* feat: add instance level IAM policy

* docs: update description

* docs: add document snippets

* lint: lint
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
* Reads and filters WIP, working Reads tests and current format for Reads snippets

* working tests for solo filters

* Composing filters

* add bulk region tags

* Change testing instance

* Linted

* feat: implement instance and table level IAM policy (googleapis#584)

* feat: add table level IAM policy controls

* lint: lint

* feat: add instance level IAM policy

* docs: update description

* docs: add document snippets

* lint: lint

* Linted
Fixed headers
Removed unnceccessary asyncs
Arrow functions where possible

* Arrow functions

* destructure Bigtable require

* Using snapshots for testing

* Change functions to use a switch

* Fix timezone issue for tests

* Lint snapshot files

* Clean up loops, add update snapshot method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants