chore(testproxy): Address the TestReadRows_Retry_StreamReset test#1546
Merged
gcf-merge-on-green[bot] merged 5 commits intomainfrom Dec 13, 2024
Merged
chore(testproxy): Address the TestReadRows_Retry_StreamReset test#1546gcf-merge-on-green[bot] merged 5 commits intomainfrom
gcf-merge-on-green[bot] merged 5 commits intomainfrom
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
kevkim-codes
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix in the test runner was made to allow a slightly different ReadRows request for full table scans and a downstream grpc change in version 1.12.4 was made so that the TestReadRows_Retry_StreamReset conformance test will pass.