fix: update another conformance test to determine if request is full table scan#218
Merged
fix: update another conformance test to determine if request is full table scan#218
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
mutianf
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The NodeJS CBT client fails the TestReadRows_Retry_StreamReset test because the first ReadRows request contains one empty row range instead of no row ranges at all due to this change. The test should allow this first request for a full table scan to be slightly different from other clients as this was done for the TestReadRows_Retry_PausedScan test.
Alternative considered
If we move the code that adds an empty range to execute after the first request when the first error is handled then TestReadRows_Retry_StreamReset will pass without these changes. This client library change is probably not worth the risk at least until an audit is done that will catch all side effects.