feat(cloudsqlpg): run SELECT 1 after successful connection attempt#2997
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the initialization of the Cloud SQL PostgreSQL source by adding a SELECT 1 health check and ensuring the connection pool is properly closed upon failure of either the initial ping or the health check. I have no feedback to provide.
duwenxin99
approved these changes
Apr 8, 2026
Contributor
|
/gcbrun |
github-actions Bot
pushed a commit
to AnmolShukla2002/genai-toolbox
that referenced
this pull request
Apr 9, 2026
…tempt (googleapis#2997) ## Description > Should include a concise description of the changes (bug or feature), it's > impact, along with a summary of the solution Update the initialization logic to execute a "SELECT 1" statement immediately after a successful ping. This confirms that the database engine is not only reachable but also ready to parse and execute SQL commands. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#2996 6ed9700
Yuan325
added a commit
that referenced
this pull request
Apr 10, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0](v0.32.0...v1.0.0) (2026-04-10) > [!IMPORTANT] > This is the first stable release. Please review the [UPGRADING.md](UPGRADING.md) guide for instructions on migrating from previous beta versions. ### ⚠ BREAKING CHANGES * **tools/elasticsearch:** add vector search support and remove query passing through param ([#2891](#2891)) * **tools/looker:** refactor looker-git-branch tool into 5 separate tools ([#2976](#2976)) ### Features * **auth:** Support opaque token validation for `generic` authService ([#2944](#2944)) ([c924701](c924701)) * **cloudsqlpg:** Run `SELECT 1` after successful connection attempt ([#2997](#2997)) ([6ed9700](6ed9700)) * **tools/bigquerysql:** Add semantic search support ([#2890](#2890)) ([862c396](862c396)) * **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary ES/QL queries ([#3013](#3013)) ([ae49fb7](ae49fb7)) * **tools/elasticsearch:** Add vector search support and remove query passing through param ([#2891](#2891)) ([d44e879](d44e879)) * **tools/looker:** Refactor looker-git-branch tool into 5 separate tools ([#2976](#2976)) ([b2472d4](b2472d4)) * **tools/mysql:** Add list-table-stats-tool to list table statistics in MySQL and Cloud SQL MySQL source. ([#2938](#2938)) ([dc2c2b4](dc2c2b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0](v0.32.0...v1.0.0) (2026-04-10) > [!IMPORTANT] > This is the first stable release. Please review the [UPGRADING.md](UPGRADING.md) guide for instructions on migrating from previous beta versions. ### ⚠ BREAKING CHANGES * **tools/elasticsearch:** add vector search support and remove query passing through param ([#2891](#2891)) * **tools/looker:** refactor looker-git-branch tool into 5 separate tools ([#2976](#2976)) ### Features * **auth:** Support opaque token validation for `generic` authService ([#2944](#2944)) ([c924701](c924701)) * **cloudsqlpg:** Run `SELECT 1` after successful connection attempt ([#2997](#2997)) ([6ed9700](6ed9700)) * **tools/bigquerysql:** Add semantic search support ([#2890](#2890)) ([862c396](862c396)) * **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary ES/QL queries ([#3013](#3013)) ([ae49fb7](ae49fb7)) * **tools/elasticsearch:** Add vector search support and remove query passing through param ([#2891](#2891)) ([d44e879](d44e879)) * **tools/looker:** Refactor looker-git-branch tool into 5 separate tools ([#2976](#2976)) ([b2472d4](b2472d4)) * **tools/mysql:** Add list-table-stats-tool to list table statistics in MySQL and Cloud SQL MySQL source. ([#2938](#2938)) ([dc2c2b4](dc2c2b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
github-actions Bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Apr 10, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0) (2026-04-10) > [!IMPORTANT] > This is the first stable release. Please review the [UPGRADING.md](UPGRADING.md) guide for instructions on migrating from previous beta versions. ### ⚠ BREAKING CHANGES * **tools/elasticsearch:** add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) * **tools/looker:** refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ### Features * **auth:** Support opaque token validation for `generic` authService ([googleapis#2944](googleapis#2944)) ([c924701](googleapis@c924701)) * **cloudsqlpg:** Run `SELECT 1` after successful connection attempt ([googleapis#2997](googleapis#2997)) ([6ed9700](googleapis@6ed9700)) * **tools/bigquerysql:** Add semantic search support ([googleapis#2890](googleapis#2890)) ([862c396](googleapis@862c396)) * **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary ES/QL queries ([googleapis#3013](googleapis#3013)) ([ae49fb7](googleapis@ae49fb7)) * **tools/elasticsearch:** Add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) ([d44e879](googleapis@d44e879)) * **tools/looker:** Refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ([b2472d4](googleapis@b2472d4)) * **tools/mysql:** Add list-table-stats-tool to list table statistics in MySQL and Cloud SQL MySQL source. ([googleapis#2938](googleapis#2938)) ([dc2c2b4](googleapis@dc2c2b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
github-actions Bot
pushed a commit
to pepe57/genai-toolbox
that referenced
this pull request
Apr 10, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0) (2026-04-10) > [!IMPORTANT] > This is the first stable release. Please review the [UPGRADING.md](UPGRADING.md) guide for instructions on migrating from previous beta versions. ### ⚠ BREAKING CHANGES * **tools/elasticsearch:** add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) * **tools/looker:** refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ### Features * **auth:** Support opaque token validation for `generic` authService ([googleapis#2944](googleapis#2944)) ([c924701](googleapis@c924701)) * **cloudsqlpg:** Run `SELECT 1` after successful connection attempt ([googleapis#2997](googleapis#2997)) ([6ed9700](googleapis@6ed9700)) * **tools/bigquerysql:** Add semantic search support ([googleapis#2890](googleapis#2890)) ([862c396](googleapis@862c396)) * **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary ES/QL queries ([googleapis#3013](googleapis#3013)) ([ae49fb7](googleapis@ae49fb7)) * **tools/elasticsearch:** Add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) ([d44e879](googleapis@d44e879)) * **tools/looker:** Refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ([b2472d4](googleapis@b2472d4)) * **tools/mysql:** Add list-table-stats-tool to list table statistics in MySQL and Cloud SQL MySQL source. ([googleapis#2938](googleapis#2938)) ([dc2c2b4](googleapis@dc2c2b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
github-actions Bot
pushed a commit
to anikasharma03/genai-toolbox
that referenced
this pull request
Apr 10, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0) (2026-04-10) > [!IMPORTANT] > This is the first stable release. Please review the [UPGRADING.md](UPGRADING.md) guide for instructions on migrating from previous beta versions. ### ⚠ BREAKING CHANGES * **tools/elasticsearch:** add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) * **tools/looker:** refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ### Features * **auth:** Support opaque token validation for `generic` authService ([googleapis#2944](googleapis#2944)) ([c924701](googleapis@c924701)) * **cloudsqlpg:** Run `SELECT 1` after successful connection attempt ([googleapis#2997](googleapis#2997)) ([6ed9700](googleapis@6ed9700)) * **tools/bigquerysql:** Add semantic search support ([googleapis#2890](googleapis#2890)) ([862c396](googleapis@862c396)) * **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary ES/QL queries ([googleapis#3013](googleapis#3013)) ([ae49fb7](googleapis@ae49fb7)) * **tools/elasticsearch:** Add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) ([d44e879](googleapis@d44e879)) * **tools/looker:** Refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ([b2472d4](googleapis@b2472d4)) * **tools/mysql:** Add list-table-stats-tool to list table statistics in MySQL and Cloud SQL MySQL source. ([googleapis#2938](googleapis#2938)) ([dc2c2b4](googleapis@dc2c2b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
github-actions Bot
pushed a commit
to pavankrishna13/genai-toolbox
that referenced
this pull request
Apr 10, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0) (2026-04-10) > [!IMPORTANT] > This is the first stable release. Please review the [UPGRADING.md](UPGRADING.md) guide for instructions on migrating from previous beta versions. ### ⚠ BREAKING CHANGES * **tools/elasticsearch:** add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) * **tools/looker:** refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ### Features * **auth:** Support opaque token validation for `generic` authService ([googleapis#2944](googleapis#2944)) ([c924701](googleapis@c924701)) * **cloudsqlpg:** Run `SELECT 1` after successful connection attempt ([googleapis#2997](googleapis#2997)) ([6ed9700](googleapis@6ed9700)) * **tools/bigquerysql:** Add semantic search support ([googleapis#2890](googleapis#2890)) ([862c396](googleapis@862c396)) * **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary ES/QL queries ([googleapis#3013](googleapis#3013)) ([ae49fb7](googleapis@ae49fb7)) * **tools/elasticsearch:** Add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) ([d44e879](googleapis@d44e879)) * **tools/looker:** Refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ([b2472d4](googleapis@b2472d4)) * **tools/mysql:** Add list-table-stats-tool to list table statistics in MySQL and Cloud SQL MySQL source. ([googleapis#2938](googleapis#2938)) ([dc2c2b4](googleapis@dc2c2b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
github-actions Bot
pushed a commit
to Jaleel-zhu/genai-toolbox
that referenced
this pull request
Apr 10, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0) (2026-04-10) > [!IMPORTANT] > This is the first stable release. Please review the [UPGRADING.md](UPGRADING.md) guide for instructions on migrating from previous beta versions. ### ⚠ BREAKING CHANGES * **tools/elasticsearch:** add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) * **tools/looker:** refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ### Features * **auth:** Support opaque token validation for `generic` authService ([googleapis#2944](googleapis#2944)) ([c924701](googleapis@c924701)) * **cloudsqlpg:** Run `SELECT 1` after successful connection attempt ([googleapis#2997](googleapis#2997)) ([6ed9700](googleapis@6ed9700)) * **tools/bigquerysql:** Add semantic search support ([googleapis#2890](googleapis#2890)) ([862c396](googleapis@862c396)) * **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary ES/QL queries ([googleapis#3013](googleapis#3013)) ([ae49fb7](googleapis@ae49fb7)) * **tools/elasticsearch:** Add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) ([d44e879](googleapis@d44e879)) * **tools/looker:** Refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ([b2472d4](googleapis@b2472d4)) * **tools/mysql:** Add list-table-stats-tool to list table statistics in MySQL and Cloud SQL MySQL source. ([googleapis#2938](googleapis#2938)) ([dc2c2b4](googleapis@dc2c2b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
hiracky16
pushed a commit
to hiracky16/mcp-toolbox
that referenced
this pull request
Apr 14, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0) (2026-04-10) > [!IMPORTANT] > This is the first stable release. Please review the [UPGRADING.md](UPGRADING.md) guide for instructions on migrating from previous beta versions. ### ⚠ BREAKING CHANGES * **tools/elasticsearch:** add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) * **tools/looker:** refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ### Features * **auth:** Support opaque token validation for `generic` authService ([googleapis#2944](googleapis#2944)) ([c924701](googleapis@c924701)) * **cloudsqlpg:** Run `SELECT 1` after successful connection attempt ([googleapis#2997](googleapis#2997)) ([6ed9700](googleapis@6ed9700)) * **tools/bigquerysql:** Add semantic search support ([googleapis#2890](googleapis#2890)) ([862c396](googleapis@862c396)) * **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary ES/QL queries ([googleapis#3013](googleapis#3013)) ([ae49fb7](googleapis@ae49fb7)) * **tools/elasticsearch:** Add vector search support and remove query passing through param ([googleapis#2891](googleapis#2891)) ([d44e879](googleapis@d44e879)) * **tools/looker:** Refactor looker-git-branch tool into 5 separate tools ([googleapis#2976](googleapis#2976)) ([b2472d4](googleapis@b2472d4)) * **tools/mysql:** Add list-table-stats-tool to list table statistics in MySQL and Cloud SQL MySQL source. ([googleapis#2938](googleapis#2938)) ([dc2c2b4](googleapis@dc2c2b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the initialization logic to execute a "SELECT 1" statement immediately after a successful ping. This confirms that the database engine is not only reachable but also ready to parse and execute SQL commands.
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #2996