Skip to content

feat(tools/looker)!: refactor looker-git-branch tool into 5 separate tools#2976

Merged
drstrangelooker merged 1 commit into
mainfrom
looker-git-branch
Apr 9, 2026
Merged

feat(tools/looker)!: refactor looker-git-branch tool into 5 separate tools#2976
drstrangelooker merged 1 commit into
mainfrom
looker-git-branch

Conversation

@drstrangelooker

Copy link
Copy Markdown
Contributor

Description

refactor looker-git-branch tool into 5 separate tools with proper annotations to isolate readonly and destructive tool actions

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

@drstrangelooker drstrangelooker requested review from a team as code owners April 7, 2026 21:31
@drstrangelooker

Copy link
Copy Markdown
Contributor Author

got this feedback on another tool -

This new tool doesn't align well with our Style Guide https://mcp-toolbox.dev/reference/style-guide/. Not blocking, but take a look

Mixing Read and Write Operations
The most significant violation is the combination of list, get, create, update, and delete operations into a single tool > via an operation parameter.

Style Guide Rule: "Never mix read and write logic in a single function. This enables clear consent models where users can auto-approve low-risk reads but must manually approve destructive writes" (source).

This change addresses the same problem with this tool.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors Looker git branch management by splitting the monolithic project_git_branch tool into five specialized tools: list_git_branches, get_git_branch, create_git_branch, switch_git_branch, and delete_git_branch. The changes include new Go implementations, updated documentation, and revised integration tests. Feedback was provided to correct the copyright year in several new files, which is currently set to 2026.

Comment thread internal/tools/looker/lookergetgitbranch/lookergetgitbranch.go
@drstrangelooker drstrangelooker force-pushed the looker-git-branch branch 2 times, most recently from bbf7492 to 5508755 Compare April 8, 2026 13:50
Comment thread .gitignore
@Yuan325 Yuan325 changed the title fix(tools/looker): refactor looker-git-branch tool into 5 separate tools feat(tools/looker)!: refactor looker-git-branch tool into 5 separate tools Apr 9, 2026
@drstrangelooker drstrangelooker force-pushed the looker-git-branch branch 5 times, most recently from b5233c9 to c14a6e6 Compare April 9, 2026 18:39
@drstrangelooker drstrangelooker enabled auto-merge (squash) April 9, 2026 18:54

@Yuan325 Yuan325 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

…ols with proper annotations to isolate readonly and destructive tool actions
@drstrangelooker drstrangelooker added the release candidate Use label to signal PR should be included in the next release. label Apr 9, 2026
@drstrangelooker drstrangelooker merged commit b2472d4 into main Apr 9, 2026
32 checks passed
@drstrangelooker drstrangelooker deleted the looker-git-branch branch April 9, 2026 19:39
@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

🧨 Preview deployments removed.

Cloudflare Pages environments for pr-2976 have been deleted.

github-actions Bot pushed a commit that referenced this pull request Apr 9, 2026
…eparate tools (#2976)

## Description

refactor looker-git-branch tool into 5 separate tools with proper
annotations to isolate readonly and destructive tool actions

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [x] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
- [x] Make sure to add `!` if this involve a breaking change b2472d4
github-actions Bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Apr 9, 2026
…eparate tools (googleapis#2976)

## Description

refactor looker-git-branch tool into 5 separate tools with proper
annotations to isolate readonly and destructive tool actions

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [x] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
- [x] Make sure to add `!` if this involve a breaking change b2472d4
Yuan325 added a commit that referenced this pull request Apr 10, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.0.0](v0.32.0...v1.0.0)
(2026-04-10)


> [!IMPORTANT]
> This is the first stable release. Please review the
[UPGRADING.md](UPGRADING.md) guide for instructions on migrating from
previous beta versions.


### ⚠ BREAKING CHANGES

* **tools/elasticsearch:** add vector search support and remove query
passing through param
([#2891](#2891))
* **tools/looker:** refactor looker-git-branch tool into 5 separate
tools ([#2976](#2976))

### Features

* **auth:** Support opaque token validation for `generic` authService
([#2944](#2944))
([c924701](c924701))
* **cloudsqlpg:** Run `SELECT 1` after successful connection attempt
([#2997](#2997))
([6ed9700](6ed9700))
* **tools/bigquerysql:** Add semantic search support
([#2890](#2890))
([862c396](862c396))
* **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary
ES/QL queries
([#3013](#3013))
([ae49fb7](ae49fb7))
* **tools/elasticsearch:** Add vector search support and remove query
passing through param
([#2891](#2891))
([d44e879](d44e879))
* **tools/looker:** Refactor looker-git-branch tool into 5 separate
tools ([#2976](#2976))
([b2472d4](b2472d4))
* **tools/mysql:** Add list-table-stats-tool to list table statistics in
MySQL and Cloud SQL MySQL source.
([#2938](#2938))
([dc2c2b4](dc2c2b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
github-actions Bot pushed a commit that referenced this pull request Apr 10, 2026
🤖 I have created a release *beep* *boop*
---

##
[1.0.0](v0.32.0...v1.0.0)
(2026-04-10)

> [!IMPORTANT]
> This is the first stable release. Please review the
[UPGRADING.md](UPGRADING.md) guide for instructions on migrating from
previous beta versions.

### ⚠ BREAKING CHANGES

* **tools/elasticsearch:** add vector search support and remove query
passing through param
([#2891](#2891))
* **tools/looker:** refactor looker-git-branch tool into 5 separate
tools ([#2976](#2976))

### Features

* **auth:** Support opaque token validation for `generic` authService
([#2944](#2944))
([c924701](c924701))
* **cloudsqlpg:** Run `SELECT 1` after successful connection attempt
([#2997](#2997))
([6ed9700](6ed9700))
* **tools/bigquerysql:** Add semantic search support
([#2890](#2890))
([862c396](862c396))
* **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary
ES/QL queries
([#3013](#3013))
([ae49fb7](ae49fb7))
* **tools/elasticsearch:** Add vector search support and remove query
passing through param
([#2891](#2891))
([d44e879](d44e879))
* **tools/looker:** Refactor looker-git-branch tool into 5 separate
tools ([#2976](#2976))
([b2472d4](b2472d4))
* **tools/mysql:** Add list-table-stats-tool to list table statistics in
MySQL and Cloud SQL MySQL source.
([#2938](#2938))
([dc2c2b4](dc2c2b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
github-actions Bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Apr 10, 2026
🤖 I have created a release *beep* *boop*
---

##
[1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0)
(2026-04-10)

> [!IMPORTANT]
> This is the first stable release. Please review the
[UPGRADING.md](UPGRADING.md) guide for instructions on migrating from
previous beta versions.

### ⚠ BREAKING CHANGES

* **tools/elasticsearch:** add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
* **tools/looker:** refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))

### Features

* **auth:** Support opaque token validation for `generic` authService
([googleapis#2944](googleapis#2944))
([c924701](googleapis@c924701))
* **cloudsqlpg:** Run `SELECT 1` after successful connection attempt
([googleapis#2997](googleapis#2997))
([6ed9700](googleapis@6ed9700))
* **tools/bigquerysql:** Add semantic search support
([googleapis#2890](googleapis#2890))
([862c396](googleapis@862c396))
* **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary
ES/QL queries
([googleapis#3013](googleapis#3013))
([ae49fb7](googleapis@ae49fb7))
* **tools/elasticsearch:** Add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
([d44e879](googleapis@d44e879))
* **tools/looker:** Refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))
([b2472d4](googleapis@b2472d4))
* **tools/mysql:** Add list-table-stats-tool to list table statistics in
MySQL and Cloud SQL MySQL source.
([googleapis#2938](googleapis#2938))
([dc2c2b4](googleapis@dc2c2b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
github-actions Bot pushed a commit to pepe57/genai-toolbox that referenced this pull request Apr 10, 2026
🤖 I have created a release *beep* *boop*
---

##
[1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0)
(2026-04-10)

> [!IMPORTANT]
> This is the first stable release. Please review the
[UPGRADING.md](UPGRADING.md) guide for instructions on migrating from
previous beta versions.

### ⚠ BREAKING CHANGES

* **tools/elasticsearch:** add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
* **tools/looker:** refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))

### Features

* **auth:** Support opaque token validation for `generic` authService
([googleapis#2944](googleapis#2944))
([c924701](googleapis@c924701))
* **cloudsqlpg:** Run `SELECT 1` after successful connection attempt
([googleapis#2997](googleapis#2997))
([6ed9700](googleapis@6ed9700))
* **tools/bigquerysql:** Add semantic search support
([googleapis#2890](googleapis#2890))
([862c396](googleapis@862c396))
* **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary
ES/QL queries
([googleapis#3013](googleapis#3013))
([ae49fb7](googleapis@ae49fb7))
* **tools/elasticsearch:** Add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
([d44e879](googleapis@d44e879))
* **tools/looker:** Refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))
([b2472d4](googleapis@b2472d4))
* **tools/mysql:** Add list-table-stats-tool to list table statistics in
MySQL and Cloud SQL MySQL source.
([googleapis#2938](googleapis#2938))
([dc2c2b4](googleapis@dc2c2b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
github-actions Bot pushed a commit to anikasharma03/genai-toolbox that referenced this pull request Apr 10, 2026
🤖 I have created a release *beep* *boop*
---

##
[1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0)
(2026-04-10)

> [!IMPORTANT]
> This is the first stable release. Please review the
[UPGRADING.md](UPGRADING.md) guide for instructions on migrating from
previous beta versions.

### ⚠ BREAKING CHANGES

* **tools/elasticsearch:** add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
* **tools/looker:** refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))

### Features

* **auth:** Support opaque token validation for `generic` authService
([googleapis#2944](googleapis#2944))
([c924701](googleapis@c924701))
* **cloudsqlpg:** Run `SELECT 1` after successful connection attempt
([googleapis#2997](googleapis#2997))
([6ed9700](googleapis@6ed9700))
* **tools/bigquerysql:** Add semantic search support
([googleapis#2890](googleapis#2890))
([862c396](googleapis@862c396))
* **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary
ES/QL queries
([googleapis#3013](googleapis#3013))
([ae49fb7](googleapis@ae49fb7))
* **tools/elasticsearch:** Add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
([d44e879](googleapis@d44e879))
* **tools/looker:** Refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))
([b2472d4](googleapis@b2472d4))
* **tools/mysql:** Add list-table-stats-tool to list table statistics in
MySQL and Cloud SQL MySQL source.
([googleapis#2938](googleapis#2938))
([dc2c2b4](googleapis@dc2c2b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
github-actions Bot pushed a commit to pavankrishna13/genai-toolbox that referenced this pull request Apr 10, 2026
🤖 I have created a release *beep* *boop*
---

##
[1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0)
(2026-04-10)

> [!IMPORTANT]
> This is the first stable release. Please review the
[UPGRADING.md](UPGRADING.md) guide for instructions on migrating from
previous beta versions.

### ⚠ BREAKING CHANGES

* **tools/elasticsearch:** add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
* **tools/looker:** refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))

### Features

* **auth:** Support opaque token validation for `generic` authService
([googleapis#2944](googleapis#2944))
([c924701](googleapis@c924701))
* **cloudsqlpg:** Run `SELECT 1` after successful connection attempt
([googleapis#2997](googleapis#2997))
([6ed9700](googleapis@6ed9700))
* **tools/bigquerysql:** Add semantic search support
([googleapis#2890](googleapis#2890))
([862c396](googleapis@862c396))
* **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary
ES/QL queries
([googleapis#3013](googleapis#3013))
([ae49fb7](googleapis@ae49fb7))
* **tools/elasticsearch:** Add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
([d44e879](googleapis@d44e879))
* **tools/looker:** Refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))
([b2472d4](googleapis@b2472d4))
* **tools/mysql:** Add list-table-stats-tool to list table statistics in
MySQL and Cloud SQL MySQL source.
([googleapis#2938](googleapis#2938))
([dc2c2b4](googleapis@dc2c2b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
github-actions Bot pushed a commit to Jaleel-zhu/genai-toolbox that referenced this pull request Apr 10, 2026
🤖 I have created a release *beep* *boop*
---

##
[1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0)
(2026-04-10)

> [!IMPORTANT]
> This is the first stable release. Please review the
[UPGRADING.md](UPGRADING.md) guide for instructions on migrating from
previous beta versions.

### ⚠ BREAKING CHANGES

* **tools/elasticsearch:** add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
* **tools/looker:** refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))

### Features

* **auth:** Support opaque token validation for `generic` authService
([googleapis#2944](googleapis#2944))
([c924701](googleapis@c924701))
* **cloudsqlpg:** Run `SELECT 1` after successful connection attempt
([googleapis#2997](googleapis#2997))
([6ed9700](googleapis@6ed9700))
* **tools/bigquerysql:** Add semantic search support
([googleapis#2890](googleapis#2890))
([862c396](googleapis@862c396))
* **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary
ES/QL queries
([googleapis#3013](googleapis#3013))
([ae49fb7](googleapis@ae49fb7))
* **tools/elasticsearch:** Add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
([d44e879](googleapis@d44e879))
* **tools/looker:** Refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))
([b2472d4](googleapis@b2472d4))
* **tools/mysql:** Add list-table-stats-tool to list table statistics in
MySQL and Cloud SQL MySQL source.
([googleapis#2938](googleapis#2938))
([dc2c2b4](googleapis@dc2c2b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8b07b2d
hiracky16 pushed a commit to hiracky16/mcp-toolbox that referenced this pull request Apr 14, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.0.0](googleapis/mcp-toolbox@v0.32.0...v1.0.0)
(2026-04-10)


> [!IMPORTANT]
> This is the first stable release. Please review the
[UPGRADING.md](UPGRADING.md) guide for instructions on migrating from
previous beta versions.


### ⚠ BREAKING CHANGES

* **tools/elasticsearch:** add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
* **tools/looker:** refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))

### Features

* **auth:** Support opaque token validation for `generic` authService
([googleapis#2944](googleapis#2944))
([c924701](googleapis@c924701))
* **cloudsqlpg:** Run `SELECT 1` after successful connection attempt
([googleapis#2997](googleapis#2997))
([6ed9700](googleapis@6ed9700))
* **tools/bigquerysql:** Add semantic search support
([googleapis#2890](googleapis#2890))
([862c396](googleapis@862c396))
* **tools/elasticsearch-execute-esql:** Add Tool to execute arbitrary
ES/QL queries
([googleapis#3013](googleapis#3013))
([ae49fb7](googleapis@ae49fb7))
* **tools/elasticsearch:** Add vector search support and remove query
passing through param
([googleapis#2891](googleapis#2891))
([d44e879](googleapis@d44e879))
* **tools/looker:** Refactor looker-git-branch tool into 5 separate
tools ([googleapis#2976](googleapis#2976))
([b2472d4](googleapis@b2472d4))
* **tools/mysql:** Add list-table-stats-tool to list table statistics in
MySQL and Cloud SQL MySQL source.
([googleapis#2938](googleapis#2938))
([dc2c2b4](googleapis@dc2c2b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release candidate Use label to signal PR should be included in the next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants