Skip to content

chore(tools/bigquery): decouple bigquery source from tools#2060

Merged
Yuan325 merged 2 commits into
config-branchfrom
config-bigquery
Dec 15, 2025
Merged

chore(tools/bigquery): decouple bigquery source from tools#2060
Yuan325 merged 2 commits into
config-branchfrom
config-bigquery

Conversation

@Yuan325

@Yuan325 Yuan325 commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Description

Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

@gemini-code-assist

gemini-code-assist Bot commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant architectural refactoring for BigQuery tools by decoupling them from direct BigQuery source implementations. The change centralizes the management and provision of BigQuery client, session, and authorization details within a SourceProvider. This enhances modularity, reduces tight coupling between tools and specific BigQuery configurations, and makes the tools more flexible and easier to maintain by allowing them to operate with any compatible BigQuery source provided by the resource manager.

Highlights

  • Decoupling BigQuery Source from Tools: The BigQuery-related tools (e.g., bigqueryanalyzecontribution, bigqueryexecutesql, bigqueryforecast, bigquerygetdatasetinfo, bigquerygettableinfo, bigquerylistdatasetids, bigquerylisttableids, bigquerysearchcatalog, bigquerysql, bigqueryconversationalanalytics) no longer directly store BigQuery client, session, authorization, or configuration details. Instead, these tools now dynamically retrieve all necessary BigQuery-related functionalities from a SourceProvider (resource manager) at runtime.
  • Simplified Tool Structs: The Tool structs across all BigQuery tools have been significantly simplified by removing fields that previously held BigQuery-specific client, service, session, and authorization information. This reduces the tools' internal state and direct dependencies.
  • Dynamic Resource Retrieval: The Invoke and RequiresClientAuthorization methods in each BigQuery tool have been updated to fetch the compatibleSource from the resourceMgr and then call the appropriate BigQuery-related methods (e.g., BigQueryClient(), BigQuerySession(), UseClientAuthorization(), IsDatasetAllowed()) on that retrieved source. This ensures that the tools operate with the correct BigQuery context provided by the resource manager.
  • Removed Static Compatibility Checks: The static compatibleSources variables and associated validation logic have been removed from the BigQuery tool packages. Compatibility is now checked dynamically when a source is retrieved from the SourceProvider and type-asserted to the compatibleSource interface.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 27, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively decouples the BigQuery source from the tools by retrieving the source from the ResourceManager at invocation time. The changes are consistent across all modified BigQuery tools.

My main feedback is about code duplication. The logic for retrieving and type-asserting the source is repeated in Invoke and RequiresClientAuthorization methods in every tool file. I've left a comment in bigqueryanalyzecontribution.go with a suggestion to extract this logic into a helper method to improve maintainability. This suggestion is applicable to all the other tool files modified in this PR.

Overall, this is a good refactoring that improves the design.

Comment thread internal/tools/bigquery/bigqueryanalyzecontribution/bigqueryanalyzecontribution.go
@averikitsch averikitsch assigned averikitsch and unassigned duwenxin99 Dec 1, 2025
Base automatically changed from config-server to config-branch December 9, 2025 01:36
@Yuan325 Yuan325 requested review from a team December 9, 2025 01:36
averikitsch
averikitsch approved these changes Dec 12, 2025
View reviewed changes

@averikitsch averikitsch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see question before merging

@Yuan325
chore: move token source into invoke function (#2173)
39d4c99 
Move token source from Tool struct into invoke() function.
@Yuan325 Yuan325 merged commit 0b87628 into config-branch Dec 15, 2025
6 of 11 checks passed
@Yuan325 Yuan325 deleted the config-bigquery branch December 15, 2025 19:01
Yuan325 added a commit that referenced this pull request Dec 17, 2025
@Yuan325
chore(tools/bigquery): decouple bigquery source from tools (#2060)
a44730d 
## Description

Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.


## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [ ] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>
Yuan325 added a commit that referenced this pull request Dec 18, 2025
@Yuan325
chore(tools/bigquery): decouple bigquery source from tools (#2060)
7889935 
## Description

Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.


## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [ ] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>
Yuan325 added a commit that referenced this pull request Dec 19, 2025
@Yuan325
chore(tools/bigquery): decouple bigquery source from tools (#2060)
6958d17 
## Description

Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.


## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [ ] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>
Yuan325 added a commit that referenced this pull request Dec 19, 2025
@Yuan325
chore(tools/bigquery): decouple bigquery source from tools (#2060)
d868f44 
## Description

Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.


## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [ ] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

@shobsi shobsi shobsi approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yuan325 @averikitsch @shobsi @duwenxin99