Skip to content

chore: move token source into invoke function#2173

Merged
Yuan325 merged 1 commit into
config-bigqueryfrom
config-bq-token
Dec 15, 2025
Merged

chore: move token source into invoke function#2173
Yuan325 merged 1 commit into
config-bigqueryfrom
config-bq-token

Conversation

@Yuan325

@Yuan325 Yuan325 commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

Move token source from Tool struct into invoke() function.

@Yuan325 Yuan325 requested a review from a team December 13, 2025 04:15
@gemini-code-assist

gemini-code-assist Bot commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the BigQuery conversational analytics tool by relocating the acquisition of the OAuth2 token source. Previously, the token source was obtained during the tool's initialization and stored within the Tool struct. This change moves the token source acquisition to the Invoke function, ensuring that the token is fetched only when the tool is actively used. This improves resource management and streamlines the Tool struct.

Highlights

  • Refactored Token Source Acquisition: The oauth2.TokenSource for BigQuery is now acquired within the Invoke function instead of during the Initialize function.
  • Streamlined Tool Struct: The TokenSource field has been removed from the Tool struct, making the struct definition cleaner and reducing its memory footprint.
  • Deferred Resource Allocation: Token source acquisition, which might involve network calls or other resource-intensive operations, is now deferred until the tool's Invoke method is called, potentially improving initialization performance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 13, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the bigquery-conversational-analytics tool to acquire the OAuth2 token source within the Invoke method instead of during initialization. This is a good change that defers the token acquisition until it's needed. I've found one issue where the context passed to Invoke is being ignored in favor of a new background context, which can break context propagation for cancellation and tracing. I've left a comment with a suggestion to fix this.

Comment thread internal/tools/bigquery/bigqueryconversationalanalytics/bigqueryconversationalanalytics.go
@Yuan325 Yuan325 mentioned this pull request Dec 13, 2025
Merged
6 tasks
@Yuan325 Yuan325 merged commit 39d4c99 into config-bigquery Dec 15, 2025
6 of 11 checks passed
@Yuan325 Yuan325 deleted the config-bq-token branch December 15, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

@Genesis929 Genesis929 Genesis929 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@duwenxin99 duwenxin99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yuan325 @averikitsch @Genesis929 @duwenxin99