Skip to content

refactor: remove all references to pipeline config#980

Merged
codyoss merged 3 commits intogoogleapis:mainfrom
codyoss:rm-config
Jul 24, 2025
Merged

refactor: remove all references to pipeline config#980
codyoss merged 3 commits intogoogleapis:mainfrom
codyoss:rm-config

Conversation

@codyoss
Copy link
Copy Markdown
Member

@codyoss codyoss commented Jul 23, 2025

The current version of the generate design, post July, has no current need for the config file. Until we need this concept lets clean up the codebase. This also has the benefit of helping with some coverage details.

Fixes: #773
Fixes: #767
Updates: #744

@codyoss codyoss requested a review from a team as a code owner July 23, 2025 17:46
@codyoss codyoss requested a review from parthea July 23, 2025 17:46
The current version of the generate design, post July, has no current
need for the config file. Until we need this concepts lets clean up
the codebase. This also has the benefit of helping with some coverage
details.

Fixes: googleapis#773
Fixes: googleapis#767
Updates: googleapis#744
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.17%. Comparing base (d9f37fc) to head (ede56a1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/librarian/state.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
+ Coverage   77.97%   80.17%   +2.19%     
==========================================
  Files          17       16       -1     
  Lines        1267     1145     -122     
==========================================
- Hits          988      918      -70     
+ Misses        213      170      -43     
+ Partials       66       57       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zhumin8
zhumin8 previously approved these changes Jul 24, 2025
Copy link
Copy Markdown
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Sorry you need to resolve conflicts now.

@zhumin8 zhumin8 mentioned this pull request Jul 24, 2025
@codyoss codyoss requested a review from zhumin8 July 24, 2025 19:46
@codyoss codyoss enabled auto-merge (squash) July 24, 2025 19:46
@codyoss codyoss merged commit fba33ee into googleapis:main Jul 24, 2025
7 checks passed
julieqiu pushed a commit that referenced this pull request Jul 31, 2025
The current version of the generate design, post July, has no current
need for the config file. Until we need this concept lets clean up the
codebase. This also has the benefit of helping with some coverage
details.

Fixes: #773
Fixes: #767
Updates: #744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

librarian: redefine pipeline-config file librarian: add env-config flag

2 participants