Skip to content

test: skip SpanTest on JDK12 and higher #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thiagotnunes merged 1 commit into from
Oct 4, 2021
Merged

test: skip SpanTest on JDK12 and higher #1472

thiagotnunes merged 1 commit into from
Oct 4, 2021

Conversation

@olavloite
Copy link
Collaborator

@olavloite olavloite commented Sep 29, 2021

The trick that the SpanTest class does to change a private static final field
is no longer possible in JDK12 and higher. This test therefore needs to be
skipped when the tests are running on Java12 or higher.

Fixes the build error in #1462

@olavloite
test: skip SpanTest on JDK17 and higher
152c031 
The trick that the SpanTest class does to change a private static final field
is no longer possible in JDK12 and higher. This test therefore needs to be
skipped when the tests are running on Java12 or higher.

Fixes the build error in #1462
@olavloite olavloite requested a review from a team as a code owner September 29, 2021 08:22
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Sep 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2021
@thiagotnunes thiagotnunes added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2021
@thiagotnunes thiagotnunes added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2021
@thiagotnunes thiagotnunes changed the title test: skip SpanTest on JDK17 and higher test: skip SpanTest on JDK12 and higher Oct 3, 2021
@thiagotnunes thiagotnunes merged commit bbe7603 into main Oct 4, 2021
@thiagotnunes thiagotnunes deleted the skip-span-test-on-java12 branch October 4, 2021 04:33
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
@gcf-owl-bot @parthea
build: marking dependencies (8) non-required (googleapis#1472) (googl…
170c5fa 
…eapis#911)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Source-Link: googleapis/synthtool@72c64b7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:b2e8f445ca0e605d4bbefbfdbdf7335692d75cf1647af62243828dcc0ea4e690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagotnunes thiagotnunes thiagotnunes approved these changes

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite @thiagotnunes @yoshi-kokoro