build: add jdk 17 to java units and dependency builds #1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
added a commit
that referenced
this pull request
Sep 29, 2021
The trick that the SpanTest class does to change a private static final field is no longer possible in JDK12 and higher. This test therefore needs to be skipped when the tests are running on Java12 or higher. Fixes the build error in #1462
thiagotnunes
pushed a commit
that referenced
this pull request
Oct 4, 2021
The trick that the SpanTest class does to change a private static final field is no longer possible in JDK12 and higher. This test therefore needs to be skipped when the tests are running on Java12 or higher. Fixes the build error in #1462
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
Source-Author: Neenu Shaji <Neenu1995@users.noreply.github.com> Source-Date: Mon Sep 27 10:04:11 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: 67ab4f9f4272ad13f4b809de47fd0dec05f425ad Source-Link: googleapis/synthtool@67ab4f9
* update dependencies.sh to not pass MaxPermSize when jdk 17 is used. MaxPermSize is an unrecognized flag in jdk 17. Source-Author: BenWhitehead <BenWhitehead@users.noreply.github.com> Source-Date: Mon Sep 27 11:34:46 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: a4be3384ccb92364795d981f2863f6986fcee620 Source-Link: googleapis/synthtool@a4be338
605f469 to
8a66c27
Compare
chanseokoh
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/130eca12-d8cf-42ce-81e8-f5bf7cddb865/targets
Source-Link: googleapis/synthtool@a4be338
Source-Link: googleapis/synthtool@67ab4f9