Skip to content

chore: add options.logging in cloud build trigger configs#921

Merged
mpeddada1 merged 1 commit intomainfrom
logging-cloud-build
Oct 10, 2024
Merged

chore: add options.logging in cloud build trigger configs#921
mpeddada1 merged 1 commit intomainfrom
logging-cloud-build

Conversation

@mpeddada1
Copy link
Copy Markdown
Contributor

@mpeddada1 mpeddada1 commented Oct 9, 2024

Emulating solution in googleapis/sdk-platform-java#3223 to address the following error in newly created cloudbuild triggers:

Your build failed to run: generic::invalid_argument: if 'build.service_account' is specified, the build must either (a) specify 'build.logs_bucket', (b) use the REGIONAL_USER_OWNED_BUCKET build.options.default_logs_bucket_behavior option, or (c) use either CLOUD_LOGGING_ONLY / NONE logging options

@mpeddada1 mpeddada1 requested a review from a team October 9, 2024 21:26
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 9, 2024
@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Oct 10, 2024

The failure in downstream / dependencies (11, java-spanner) isn't related to the changes in this PR:

Error:  +-com.google.cloud:google-cloud-spanner:6.77.1-SNAPSHOT
Error:    +-com.google.api.grpc:grpc-google-common-protos:2.46.0
Error:      +-io.grpc:grpc-protobuf-lite:1.67.1 [runtime] (managed) <-- io.grpc:grpc-protobuf-lite:1.67.1 [runtime]
Error:  and
Error:  +-com.google.cloud:google-cloud-spanner:6.77.1-SNAPSHOT
Error:    +-com.google.cloud:google-cloud-monitoring:3.52.0
Error:      +-io.grpc:grpc-protobuf-lite:1.67.1 [runtime] (managed) <-- io.grpc:grpc-protobuf-lite:1.68.0 [runtime]
Error:  ]

@mpeddada1 mpeddada1 merged commit 092d2b2 into main Oct 10, 2024
@mpeddada1 mpeddada1 deleted the logging-cloud-build branch October 10, 2024 17:50
@mpeddada1 mpeddada1 mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpeddada1 @JoeWang1127