Skip to content

chore: specify options.logging in cloud build#3223

Merged
JoeWang1127 merged 2 commits intomainfrom
chore/add-logging-option
Sep 23, 2024
Merged

chore: specify options.logging in cloud build#3223
JoeWang1127 merged 2 commits intomainfrom
chore/add-logging-option

Conversation

@JoeWang1127
Copy link
Copy Markdown
Contributor

@JoeWang1127 JoeWang1127 commented Sep 23, 2024

In this PR:

  • Specify options.logging` in Cloud Build config.

The cloud build failed when pushing:

Error: Insufficient step blocks

  on ../../modules/infra_cloud_build/cloud_build.tf line 32, in resource "google_cloudbuild_trigger" "triggers":
  32:   build {

At least 1 "step" blocks are required.
  
Error: Insufficient step blocks

  on ../../modules/infra_cloud_build/cloud_build.tf line 32, in resource "google_cloudbuild_trigger" "triggers":
  32:   build {

At least 1 "step" blocks are required.

Try to resolve this issue following this answer in YAQS.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 23, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review September 23, 2024 17:10
@JoeWang1127
Copy link
Copy Markdown
Contributor Author

JoeWang1127 commented Sep 23, 2024

I didn't find where the trigger is defined in g3. I'll do a more through investigation later since this is not relevant to this change.

File .cloudbuild/library_generation/cloudbuild-library-generation-integration-tests.yaml not found

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 merged commit 9105674 into main Sep 23, 2024
@JoeWang1127 JoeWang1127 deleted the chore/add-logging-option branch September 23, 2024 17:30
@mpeddada1 mpeddada1 mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoeWang1127 @mpeddada1